MDL-62384 core_rating: Move WHERE clauses to JOIN

safatshahin · May 11, 2018 · 38e6852 · 38e6852
1 parent a339908
commit 38e6852
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/rating/classes/privacy/provider.php b/rating/classes/privacy/provider.php
@@ -139,12 +139,13 @@ public static function get_sql_join($alias, $component, $ratingarea, $itemidjoin
 
         // Join the rating table with the specified alias and the relevant join params.
         $join = "LEFT JOIN {rating} {$alias} ON ";
+        $join .= "{$alias}.userid = :ratinguserid{$count} AND ";
         $join .= "{$alias}.component = :ratingcomponent{$count} AND ";
         $join .= "{$alias}.ratingarea = :ratingarea{$count} AND ";
         $join .= "{$alias}.itemid = {$itemidjoin}";
 
         // Match against the specified user.
-        $userwhere = "{$alias}.userid = :ratinguserid{$count}";
+        $userwhere = "{$alias}.id IS NOT NULL";
 
         $params = [
             'ratingcomponent' . $count  => $component,