Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cstring and cstdint to Utils.hpp for memcmp compatibility #10

Closed
wants to merge 1 commit into from

Conversation

red436
Copy link

@red436 red436 commented Dec 26, 2023

Was not compiling on linux. Made a few changes. Not sure if this will break a windows build.

@sagamusix
Copy link
Owner

It appears that your branch is not rebased on the latest main commit, because cstring should already be included in that file. Also those changes in CMake look unrelated and incorrect (the software is called JDTools because it offers multiple tools in one binary, it's not just one tool).

@sagamusix
Copy link
Owner

The remaining missing include should be handled by cc7a069.

@sagamusix sagamusix closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants