Skip to content

Commit

Permalink
Fixed typos and grammar errors.
Browse files Browse the repository at this point in the history
This is a ghost commit! Happy Dia de los Muertos! 👻
  • Loading branch information
dfabulich committed Nov 2, 2017
1 parent c6da91f commit 5278a0a
Showing 1 changed file with 23 additions and 23 deletions.
46 changes: 23 additions & 23 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ before submitting your pull requests.

## Building

Selenium uses a custom build system aptly named
Selenium uses a custom build system, aptly named
[crazyfun](https://github.com/SeleniumHQ/selenium/wiki/Crazy-Fun-Build)
available on all fine platforms (Linux, Mac, Windows). We are in the
process of replacing crazyfun with
Expand All @@ -44,7 +44,7 @@ see directories carrying multiple build directive files.
For reference, crazyfun's build files are named *build.desc*,
while buck's are named simply *BUCK*.

Before building ensure that you have the
Before building, ensure that you have the
[most recent `chromedriver` ](https://sites.google.com/a/chromium.org/chromedriver/downloads)
available on your `$PATH`. You may have to update this from time to time.

Expand All @@ -70,7 +70,7 @@ and `run` is the action to run on that target.
As you see *build targets* scroll past in the log,
you may want to run them individually.
crazyfun can run them individually,
by target name as long as `:run` is appended (see above).
by target name, as long as `:run` is appended (see above).

To list all available targets, you can append the `-T` flag:

Expand Down Expand Up @@ -119,12 +119,12 @@ from https://github.com/facebook/watchman
* [Java 8 JDK](http://www.oracle.com/technetwork/java/javase/downloads/index.html)
* `java` and `jar` on the PATH

Although the build system is based on rake it's **strongly advised**
Although the build system is based on rake, it's **strongly advised**
to rely on the version of JRuby in `third_party/` that is invoked by
`go`. The only developer type who would want to deviate from this is
the “build maintainer” who's experimenting with a JRuby upgrade.

Note that all Selenium Java artefacts are **built with Java 8
Note that all Selenium Java artifacts are **built with Java 8
(mandatory)**. Those _will work with any Java >= 8_.

### Optional Requirements
Expand All @@ -135,18 +135,18 @@ Note that all Selenium Java artefacts are **built with Java 8
### Internet Explorer Driver

If you plan to compile the
[IE driver](https://github.com/SeleniumHQ/selenium/wiki/InternetExplorerDriver)
[IE driver](https://github.com/SeleniumHQ/selenium/wiki/InternetExplorerDriver),
you also need:

* [Visual Studio 2008](http://www.microsoft.com/visualstudio/en-gb/products/2008-editions)
* 32 and 64 bit cross compilers

The build will work on any platform, but the tests for IE will be
skipped silently, if you are not building on Windows.
skipped silently if you are not building on Windows.

## Common Tasks

For an express build of the binaries we release run the following from
For an express build of the binaries we release, run the following from
the directory containing the `Rakefile`:

```sh
Expand All @@ -155,7 +155,7 @@ the directory containing the `Rakefile`:

All build output is placed under the `build` directory. The output can
be found under `build/dist`. If an error occurs while running this
task complaining about a missing Albacore gem, the chances are you're
task complaining about a missing Albacore gem, chances are you're
using `rvm`. If this is the case, switch to the system ruby:

```sh
Expand Down Expand Up @@ -195,14 +195,14 @@ If you are interested in a single language binding, try one of:
./go test_javascript
```

To run all the tests just run:
To run all the tests, run:

```sh
./go test
```

This will detect your OS and run all the tests that are known to be
stable for every browser that's appropriate to use for all language
stable, for every browser that's appropriate to use, for all language
bindings. This can take a healthy amount of time to run.

To run the minimal logical Selenium build:
Expand All @@ -213,7 +213,7 @@ To run the minimal logical Selenium build:

As a side note, **none of the developers** run tests using
[Cygwin](http://www.cygwin.com/). It is very unlikely that the build
will work as expected if you try and use it.
will work as expected if you try to use it.

## Tour

Expand All @@ -226,17 +226,17 @@ start the development server:
./go debug-server
```

Now navigate to
Now, navigate to
[http://localhost:2310/javascript](http://localhost:2310/javascript).
You'll find the contents of the `javascript/` directory being shown.
We use the [Closure
Library](https://developers.google.com/closure/library/) for
developing much of the javascript, so now navigate to
developing much of the JavaScript, so now navigate to
[http://localhost:2310/javascript/atoms/test](http://localhost:2310/javascript/atoms/test).

The tests in this directory are normal HTML files with names ending
with `_test.html`. Click on one to load the page and run the test. You
can run all the javascript tests using:
can run all the JavaScript tests using:

```sh
./go test_javascript
Expand Down Expand Up @@ -270,38 +270,38 @@ going. Java test outputs appear in one of two places: either under
tests. If you'd like the build to be chattier, just append `log=true`
to the build command line.

# Help with *go*
# Help with `go`

More general, but basic, help for *go*
More general, but basic, help for `go`

```sh
./go --help
```

Remember, *go* is just a wrapper around
`go` is just a wrapper around
[Rake](http://rake.rubyforge.org/), so you can use the standard
commands such as `rake -T` to get more information about available
targets.

## Maven _per se_

If it is not clear already, Selenium is not built with Maven, it is
If it is not clear already, Selenium is not built with Maven. It is
built with [Buck](https://github.com/SeleniumHQ/buck),
though that is invoked with *go* as outlined above so you do not really
though that is invoked with `go` as outlined above, so you do not really
have to learn too much about that.

That said, it is possible to relatively quickly build selenium pieces
That said, it is possible to relatively quickly build Selenium pieces
for Maven to use. You are only really going to want to do this when
you are testing the cutting-edge of Selenium development (which we
welcome) against your application. Here is the quickest way to build
and deploy into you local maven repository (`~/.m2/repository`), while
and deploy into your local maven repository (`~/.m2/repository`), while
skipping Selenium's own tests.

```sh
./go maven-install
```

The maven jars should now be in your local ~/.m2/repository. You can also publish
The maven jars should now be in your local `~/.m2/repository`. You can also publish
directly using Buck:

```sh
Expand Down

0 comments on commit 5278a0a

Please sign in to comment.