Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warmup Gssoc and Kruskal's Algorithm #13 #34 #27

Closed
wants to merge 6 commits into from

Conversation

Dhiraj240
Copy link
Contributor

@Dhiraj240 Dhiraj240 commented Jun 22, 2018

Solution of a simple problem for tag-math
https://codeforces.com/problemset/problem/987/B

Copy link
Owner

@sahilbansal17 sahilbansal17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to submit this solution?
It would not pass the test cases since the limits on x and y are large, they can be upto 10^9, but the power function in C++ doesn't work for such limits.

@Dhiraj240
Copy link
Contributor Author

I forgot to verify,it failed at test case 5,i think i need to make a function.I will update both this and the issue by tomorrow.

@sahilbansal17
Copy link
Owner

@Dhiraj240 You cannot actually compute powers of such huge numbers, there is some Mathematics involved behind the actual solution since you just need to compare xy and yx.!

@Dhiraj240
Copy link
Contributor Author

It was a silly mistake of ignoring the condition on input,now its fine.

@Dhiraj240
Copy link
Contributor Author

@sahilbansal17 This pull request was not merged and when i went to give a pull request for kruskal algorithm it got updated here.Is there is a way to do multiple PRs? or something have been done by your side.

@Dhiraj240 Dhiraj240 changed the title Warmup Gssoc #13 Warmup Gssoc and Kruskal's Algorithm #13 #34 Jun 26, 2018
@Dhiraj240
Copy link
Contributor Author

Dhiraj240 commented Jun 26, 2018

@sahilbansal17 This way is fine,also ignore merge pull request #1.Consider issue #34

Copy link
Owner

@sahilbansal17 sahilbansal17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have just changed the comments in the code given on geeksforgeeks. This can't be approved. @ramitsawhney27 @arnav-mandal1234 @aditya81070 @vikasgola See into it.

@ramitsawhney27
Copy link
Collaborator

If you're going to directly pickup a code and modify it, there's a good chance we'll catch it. Just going to close this PR, feel free to take up a new issue.

@Dhiraj240
Copy link
Contributor Author

@sahilbansal17 What all you expect tell me ? Should i change the whole code? If i would have planned to just change the comment i would have done it much before.

@sahilbansal17
Copy link
Owner

@Dhiraj240 We expect you to write original code. Not copying it from somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants