-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warmup Gssoc and Kruskal's Algorithm #13 #34 #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried to submit this solution?
It would not pass the test cases since the limits on x and y are large, they can be upto 10^9, but the power function in C++ doesn't work for such limits.
I forgot to verify,it failed at test case 5,i think i need to make a function.I will update both this and the issue by tomorrow. |
@Dhiraj240 You cannot actually compute powers of such huge numbers, there is some Mathematics involved behind the actual solution since you just need to compare xy and yx.! |
It was a silly mistake of ignoring the condition on input,now its fine. |
@sahilbansal17 This pull request was not merged and when i went to give a pull request for kruskal algorithm it got updated here.Is there is a way to do multiple PRs? or something have been done by your side. |
Kruskal's Algorithm sahilbansal17#34
@sahilbansal17 This way is fine,also ignore merge pull request #1.Consider issue #34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have just changed the comments in the code given on geeksforgeeks. This can't be approved. @ramitsawhney27 @arnav-mandal1234 @aditya81070 @vikasgola See into it.
If you're going to directly pickup a code and modify it, there's a good chance we'll catch it. Just going to close this PR, feel free to take up a new issue. |
@sahilbansal17 What all you expect tell me ? Should i change the whole code? If i would have planned to just change the comment i would have done it much before. |
@Dhiraj240 We expect you to write original code. Not copying it from somewhere else. |
Solution of a simple problem for tag-math
https://codeforces.com/problemset/problem/987/B