Migrate rest of dialogs #5097
Merged
Migrate rest of dialogs #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: efedfe3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
poulch
requested review from
2can,
krzysztofzuraw and
andrzejewsky
and removed request for
2can
krzysztofzuraw
approved these changes
Aug 8, 2024
andrzejewsky
approved these changes
Aug 13, 2024
| </ConfirmButton> | ||
| </DialogActions> | ||
| </Dialog> | ||
| {maybe(() => product.variants, []).map((variant, variantIndex) => ( |
There was a problem hiding this comment.
can we get rid of "maybe" ?
poulch
added a commit
that referenced
this pull request
Aug 26, 2024
* Replace Dialog in OrderCustomerChangeDialog * Replace Dialog in OrderProductAddDialog * Replace Dialog in OrderFulfillmentTrackingDialog * Replace Dialog in OrderInvoiceEmailSendDialog * Replace Dialog in OrderCannotCancelOrderDialog and fix showing two dialogs * Replace Dialog in OrderFulfillmentApproveDialog * Replace Dialog in ProductVariantDeleteDialog * Replace Dialog in ProductExternalMediaDialog * Replace Dialog in ProductExportSteps * Replace Dialog in ProductVariantMediaSelectDialog * Replace Dialog in DiscountCountrySelectDialog * Replace Dialog in PluginSecretFieldDialog * Replace Dialog in ShippingZonePostalCodeRangeDialog * Replace Dialog in ShippingZoneCountriesAssignDialog * Replace Dialog in ShippingZoneCountriesAssignDialog * Replace Dialog in gift card export dialog * Replace Dialog in GiftCardBulkCreateSuccessDialog * Remove not used delete category dialog * Replace Dialog in SaveFilterTabDialog * Replace Dialog in MenuCreateDialog * Replace Dialog in TokenCreateDialog * Replace Dialog in ExitFormDialog * Replace Dialog in DevModePanel * Add Xl modal size * Replace Dialog in AppPermissionsDialog * Replace Dialog in DryRun * Add modal size MD * Replace Dialog in AttributeValueEditDialog * Replace Dialog in AssignMembersDialog * Replace Dialog in AssignVariantDialog * Replace Dialog in AssignProductDialog * Replace Dialog in AssignContainerDialog * Replace Dialog in AssignAttributeDialog * Add todo comment * Extract messages * Add missing test ids * Add changeset * Add Modal sizes * Update sizing * Small improvements after QA * Fix full width modals * Fix ActionDialog size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description