Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Add Cypress tags to all of the buttons (also speed up tests) #718

Merged
merged 5 commits into from
May 20, 2020
Merged

Add Cypress tags to all of the buttons (also speed up tests) #718

merged 5 commits into from
May 20, 2020

Conversation

krzysztofwolski
Copy link
Member

@krzysztofwolski krzysztofwolski commented May 18, 2020 •
edited
Loading

I want to merge this change because...
those selectors are used by cypress e2e tests.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@netlify
Copy link

netlify bot commented May 18, 2020 •
edited
Loading

Deploy preview for saleor-storefront-stage processing.

Building with commit f044ff3

https://app.netlify.com/sites/saleor-storefront-stage/deploys/5ec5110120bc560007130b3b

@krzysztofwolski krzysztofwolski changed the title Cypress all the things buttons Cypress all the buttons May 18, 2020
@krzysztofwolski krzysztofwolski force-pushed the cypress-all-the-things-buttons branch 3 times, most recently from 53641b7 to 6850937 Compare May 19, 2020 17:06
@krzysztofwolski krzysztofwolski changed the title Cypress all the buttons Add Cypress tags to all of the buttons (also speed up tests) May 19, 2020
@krzysztofwolski krzysztofwolski marked this pull request as ready for review May 19, 2020 17:31
orzechdev
orzechdev approved these changes May 20, 2020
View reviewed changes
cypress/integration/category/filters_and_sort_bar.js
@@ -65,27 +65,4 @@ describe("Category view - filtering and sorting", () => {
.should("have.length", 5);
});

it("should change order of items after changing sorting option", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, why is it removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test was not checking if its working properly , just if products are shuffled

@krzysztofwolski krzysztofwolski merged commit 4d3d249 into master May 20, 2020
@krzysztofwolski krzysztofwolski deleted the cypress-all-the-things-buttons branch May 20, 2020 12:06
Ninpo pushed a commit to collaborativ-io/saleor-storefront that referenced this pull request Aug 8, 2020
@krzysztofwolski @Ninpo
Add Cypress tags to all of the buttons (also speed up tests) (saleor#718
e914524 
)

* Remove unused modal

* Cover buttons with dataCy

* Speed up tests execution and better selectors

* Upgrade cypress

* Update changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dominik-zeglen dominik-zeglen dominik-zeglen approved these changes

@orzechdev orzechdev orzechdev approved these changes

@AlicjaSzu AlicjaSzu Awaiting requested review from AlicjaSzu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krzysztofwolski @dominik-zeglen @orzechdev