This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Refactor/add to cart #809
Merged
Refactor/add to cart #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
orzechdev
force-pushed
the
refactor/add-to-cart
branch
from
f8bfcfc
to
fa6b536
Compare
github-actions
bot
had a problem deploying
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
orzechdev
force-pushed
the
refactor/add-to-cart
branch
from
4859c24
to
4cb0033
Compare
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
krzysztofwolski
force-pushed
the
refactor/add-to-cart
branch
from
3866a22
to
d8c3100
Compare
github-actions
bot
temporarily deployed
to
storybook refactor-add-to-cart
krzysztofwolski
requested review from
orzechdev,
dominik-zeglen,
bmigirl and
AlicjaSzu
|
I recommend trying out test env to see if all working as intended ✌️ |
dominik-zeglen
suggested changes
Sep 28, 2020
krzysztofwolski
commented
Sep 28, 2020
Co-authored-by: Dominik Żegleń <flesz3@o2.pl>
Co-authored-by: Dominik Żegleń <flesz3@o2.pl>
orzechdev
reviewed
Sep 29, 2020
| storiesOf("@components/{{ componentType }}/{{pascalCase name}}", module) | ||
| .addParameters({ component: {{pascalCase name}} }) | ||
| .addDecorator(story => ( | ||
| <IntlProvider locale="en">story()</IntlProvider> |
There was a problem hiding this comment.
As IntlProvider is always added as decorator, I think it is better to add it just in one place in .storybook/OutLineDecorator.jsx, so this decoration addition would be completely removed.
There was a problem hiding this comment.
Its outside of the scope of this PR, editing existing PRs would be needed. Created Issue: https://app.clickup.com/t/2549495/SALEOR-1194
dominik-zeglen
approved these changes
Sep 29, 2020
orzechdev
approved these changes
Sep 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because...
add to basketdisplay cart overlay to avoid confusion if the product was really added to the cartPull Request Checklist
Test Environment Config
API_URI=https://master.staging.saleor.rocks/graphql/