This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 677
Set billing address in first checkout step #822
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
July 29, 2020 16:16
Inactive
This pull request introduces 1 alert when merging c4f7fec into 7831c0f - view on LGTM.com new alerts:
|
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
July 30, 2020 12:50
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
July 30, 2020 13:21
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
July 30, 2020 16:23
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
July 31, 2020 09:49
Inactive
orzechdev
force-pushed
the
refactor/move-billing-address
branch
from
July 31, 2020 10:15
2fd88ee
to
43f547a
Compare
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
July 31, 2020 10:15
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
July 31, 2020 12:24
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 3, 2020 08:55
Inactive
orzechdev
changed the title
Remove billing address form and selector from checkout payment step
Set billing address in first checkout step
Aug 3, 2020
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 3, 2020 09:07
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 3, 2020 09:22
Inactive
orzechdev
requested review from
dominik-zeglen,
krzysztofwolski and
michalina-graczyk
August 3, 2020 09:27
Task linked: CU-6yn1rv Move billing address form to 1st step |
dominik-zeglen
approved these changes
Aug 3, 2020
5 tasks
krzysztofwolski
suggested changes
Aug 4, 2020
src/@next/pages/CheckoutPage/subpages/CheckoutAddressSubpage.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 4, 2020 16:19
Inactive
orzechdev
force-pushed
the
refactor/move-billing-address
branch
from
August 5, 2020 06:41
e1cc51e
to
489b9da
Compare
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 5, 2020 06:41
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 5, 2020 07:39
Inactive
This pull request introduces 3 alerts when merging 50e0eb4 into 9239461 - view on LGTM.com new alerts:
|
orzechdev
force-pushed
the
refactor/move-billing-address
branch
from
August 5, 2020 09:53
254ec0f
to
ca69660
Compare
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 5, 2020 09:53
Inactive
This pull request introduces 3 alerts when merging ca69660 into 9bc5319 - view on LGTM.com new alerts:
|
orzechdev
force-pushed
the
refactor/move-billing-address
branch
from
August 5, 2020 10:05
ca69660
to
c80703b
Compare
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 5, 2020 10:06
Inactive
This pull request introduces 3 alerts when merging c80703b into 9bc5319 - view on LGTM.com new alerts:
|
orzechdev
force-pushed
the
refactor/move-billing-address
branch
from
August 5, 2020 10:37
c80703b
to
82c76df
Compare
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 5, 2020 10:37
Inactive
This pull request introduces 3 alerts when merging 82c76df into 9bc5319 - view on LGTM.com new alerts:
|
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 5, 2020 10:50
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 5, 2020 10:53
Inactive
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 5, 2020 11:40
Inactive
michalina-graczyk
approved these changes
Aug 5, 2020
michalina-graczyk
suggested changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove fixtures -> example.json
github-actions
bot
temporarily deployed
to
refactor-move-billing-address
August 6, 2020 07:46
Inactive
michalina-graczyk
approved these changes
Aug 6, 2020
krzysztofwolski
approved these changes
Aug 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because... it moves billing address form and selector from 3rd payment step to 1st address step in checkout page.
Screenshots
1st step:
2nd step:
Pull Request Checklist
Test Environment Config
API_URI=https://master.staging.saleor.rocks/graphql/