Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Set billing address in first checkout step #822

Merged
merged 16 commits into from
Aug 6, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Jul 29, 2020

I want to merge this change because... it moves billing address form and selector from 3rd payment step to 1st address step in checkout page.

Screenshots

1st step:

127 0 0 1_3000_checkout_payment
127 0 0 1_3000_checkout_payment (1)

2nd step:

127 0 0 1_3000_checkout_payment (2)

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to refactor-move-billing-address July 29, 2020 16:16 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2020

This pull request introduces 1 alert when merging c4f7fec into 7831c0f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions github-actions bot temporarily deployed to refactor-move-billing-address July 30, 2020 12:50 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address July 30, 2020 13:21 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address July 30, 2020 16:23 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address July 31, 2020 09:49 Inactive
@orzechdev orzechdev force-pushed the refactor/move-billing-address branch from 2fd88ee to 43f547a Compare July 31, 2020 10:15
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address July 31, 2020 10:15 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address July 31, 2020 12:24 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 3, 2020 08:55 Inactive
@orzechdev orzechdev changed the title Remove billing address form and selector from checkout payment step Set billing address in first checkout step Aug 3, 2020
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 3, 2020 09:07 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 3, 2020 09:22 Inactive
@orzechdev orzechdev marked this pull request as ready for review August 3, 2020 09:28
@patrys
Copy link
Member

patrys commented Aug 3, 2020

Task linked: CU-6yn1rv Move billing address form to 1st step

@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 4, 2020 16:19 Inactive
@orzechdev orzechdev force-pushed the refactor/move-billing-address branch from e1cc51e to 489b9da Compare August 5, 2020 06:41
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 5, 2020 06:41 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 5, 2020 07:39 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request introduces 3 alerts when merging 50e0eb4 into 9239461 - view on LGTM.com

new alerts:

  • 3 for Useless conditional

@orzechdev orzechdev force-pushed the refactor/move-billing-address branch from 254ec0f to ca69660 Compare August 5, 2020 09:53
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 5, 2020 09:53 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request introduces 3 alerts when merging ca69660 into 9bc5319 - view on LGTM.com

new alerts:

  • 3 for Useless conditional

@orzechdev orzechdev force-pushed the refactor/move-billing-address branch from ca69660 to c80703b Compare August 5, 2020 10:05
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 5, 2020 10:06 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request introduces 3 alerts when merging c80703b into 9bc5319 - view on LGTM.com

new alerts:

  • 3 for Useless conditional

@orzechdev orzechdev force-pushed the refactor/move-billing-address branch from c80703b to 82c76df Compare August 5, 2020 10:37
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 5, 2020 10:37 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request introduces 3 alerts when merging 82c76df into 9bc5319 - view on LGTM.com

new alerts:

  • 3 for Useless conditional

@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 5, 2020 10:50 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 5, 2020 10:53 Inactive
@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 5, 2020 11:40 Inactive
cypress/fixtures/example.json Outdated Show resolved Hide resolved
Copy link
Member

@michalina-graczyk michalina-graczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove fixtures -> example.json

@github-actions github-actions bot temporarily deployed to refactor-move-billing-address August 6, 2020 07:46 Inactive
@orzechdev orzechdev merged commit 46b5a80 into master Aug 6, 2020
@orzechdev orzechdev deleted the refactor/move-billing-address branch August 6, 2020 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants