Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Fix cart sidebar style #897

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Fix cart sidebar style #897

merged 2 commits into from
Sep 18, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Sep 14, 2020

I want to merge this change because... it fixes hiding item in the cart sidebar and items quantity message.

Previously it was sometimes hidden by prices amount (when the cart list was scrolled to the very end):
Zrzut ekranu 2020-09-14 o 16 28 20

Now:
Zrzut ekranu 2020-09-14 o 16 27 56

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-cart-sidebar September 14, 2020 14:33 Inactive
@orzechdev orzechdev changed the title Fix cart sidebar overflow style Fix cart sidebar style Sep 14, 2020
@github-actions github-actions bot temporarily deployed to fix-cart-sidebar September 14, 2020 14:50 Inactive
@orzechdev orzechdev marked this pull request as ready for review September 14, 2020 15:01
@patrys
Copy link
Member

patrys commented Sep 14, 2020

Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against the demo instance and it solves the problem. LGTM!

@krzysztofwolski krzysztofwolski merged commit ccabbaa into master Sep 18, 2020
@krzysztofwolski krzysztofwolski deleted the fix/cart-sidebar branch September 18, 2020 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants