This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Use only selection attributes in variant picker #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
saleor-1357-select-only-selection-variant-attributes
github-actions
bot
temporarily deployed
to
storybook saleor-1357-select-only-selection-variant-attributes
github-actions
bot
temporarily deployed
to
saleor-1357-select-only-selection-variant-attributes
github-actions
bot
temporarily deployed
to
storybook saleor-1357-select-only-selection-variant-attributes
|
Task linked: SALEOR-1357 Update variant selector in storefront |
github-actions
bot
temporarily deployed
to
saleor-1357-select-only-selection-variant-attributes
github-actions
bot
temporarily deployed
to
storybook saleor-1357-select-only-selection-variant-attributes
orzechdev
requested review from
krzysztofwolski,
dominik-zeglen,
MarekChoinski,
AlicjaSzu and
bmigirl
github-actions
bot
temporarily deployed
to
saleor-1357-select-only-selection-variant-attributes
krzysztofwolski
approved these changes
Dec 9, 2020
|
Cypress will fail because of missing products in test database. Code can be merged |
|
This pull request introduces 2 alerts when merging 8af434b into 6fd7b46 - view on LGTM.com new alerts:
|
bmigirl
approved these changes
Dec 10, 2020
8 tasks
maarcingebala
deleted the
SALEOR-1357-select-only-selection-variant-attributes
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because... it adds usage of only selection attributes in variant picker.
PR intended to be tested with API branch: feature/file-uploads
saleor/saleor#6568
Screenshots
Pull Request Checklist
Test Environment Config
API_URI=https://feature-file-uploads.api.saleor.rocks/graphql/