Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

update rich text to allow null values #996

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

bmigirl
Copy link

@bmigirl bmigirl commented Feb 22, 2021

I want to merge this change because...

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.cloud/graphql/

@bmigirl bmigirl added the wip Work in progress label Feb 22, 2021
@patrys
Copy link
Member

patrys commented Feb 22, 2021

@github-actions github-actions bot temporarily deployed to saleor-2270-update-nullable-editor-js-fields February 22, 2021 14:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-2270-update-nullable-editor-js-fields February 22, 2021 14:41 Inactive
@bmigirl bmigirl force-pushed the SALEOR-2270/update-nullable-editor-js-fields branch from 3a861f5 to dbe2dd9 Compare February 22, 2021 15:07
@bmigirl bmigirl requested review from a team, dominik-zeglen and orzechdev and removed request for a team February 22, 2021 15:07
@github-actions github-actions bot temporarily deployed to saleor-2270-update-nullable-editor-js-fields February 22, 2021 15:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-2270-update-nullable-editor-js-fields February 22, 2021 15:07 Inactive
@bmigirl bmigirl removed the wip Work in progress label Feb 22, 2021
@@ -48,6 +48,10 @@ export const getTools = async (): Promise<
export const RichTextEditorContent: React.FC<RichTextEditorContentProps> = ({
jsonData,
}) => {
if (!jsonData) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return statements should come after all hook declarations as this guarantees their call order during render phase:

https://reactjs.org/docs/hooks-rules.html#only-call-hooks-at-the-top-level

@maarcingebala maarcingebala merged commit 5fec836 into master Feb 23, 2021
@maarcingebala maarcingebala deleted the SALEOR-2270/update-nullable-editor-js-fields branch February 23, 2021 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants