Fix #9639 Re-implement local image support for tinymce #10235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBuchanan
changed the title
JackBuchanan
force-pushed
the
issue-9639
branch
2 times, most recently
from
647b7cb
to
873c6c4
Compare
serhiisamko091184
added
Status: Requires Code Review
|
Hey @JackBuchanan, thanks for your PR! Regards, |
JackBuchanan
force-pushed
the
issue-9639
branch
from
a16bd7e
to
6745add
Compare
…il signatures Implement email signatures tinymce config to match working implementation in Knowledge base module Fix salesagility#9639 - Implement local image support for email compose view and campaign email templates Updates to implement functionality into tinymce
JackBuchanan
force-pushed
the
issue-9639
branch
from
6745add
to
2f4a5a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back in support for image insert in tinyMCE/moziak editors that was removed in a previous version as raised here: #9639
Description
Re-implement local image support for email compose & email templates
Remove deprecated file_browser_callback and use new TinyCME 5 file_picker_callback
Implement use of images_upload_handler to base64 encode uploaded image to that file no longer have to be saved on public to be used
Set HTML Purifier config value - URI.AllowedSchemes to allowing saving of Base64 images
Motivation and Context
Re-adds local image support to email modules
How To Test This
Load compose view or email template edit view
See the Image Insert button in the toolbar no longer only allows path to file support but upload image support too
Upload image and save template or send email from compose view and see the image save in Base64 to the email body
Types of changes
Final checklist