-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #5680 - ics file contains SugarCRM references #6393
base: hotfix-7.10.x
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## hotfix #6393 +/- ##
=======================================
Coverage 7.8% 7.8%
=======================================
Files 3404 3404
Lines 340651 340651
=======================================
Hits 26593 26593
Misses 314058 314058 |
Assessed 👍 |
Please rebase this pull request onto hotfix-7.10.x as the hotfix branch is now specifically for 7.11.x issues. Please take a look at our contribution guidelines for more information. |
Fixed a typo in the PHPDoc, updated arrays to use the short syntax, updated the variable name to match coding standards and updated the strings to use single quotes instead of double.
89aaab0
to
ecf6155
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and approved, thanks for the contribution!
cd6253b
to
3149dea
Compare
@ApatheticCosmos do you know if this is used in the Google Calendar integration? I'm wondering if this change might force users to re-do their Google calendar configurations. |
3149dea
to
ab954a4
Compare
1609e8b
to
b06335d
Compare
Description
Fixed #5680 - ics file contains SugarCRM references
Motivation and Context
This removes SugarCRM references in ics file.
How To Test This
Types of changes
Final checklist