Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #5680 - ics file contains SugarCRM references #6393

Open
wants to merge 2 commits into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

SohanTirpude
Copy link
Contributor

Description

Fixed #5680 - ics file contains SugarCRM references

Motivation and Context

This removes SugarCRM references in ics file.

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

Codecov Report

Merging #6393 into hotfix will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           hotfix    #6393   +/-   ##
=======================================
  Coverage     7.8%     7.8%           
=======================================
  Files        3404     3404           
  Lines      340651   340651           
=======================================
  Hits        26593    26593           
  Misses     314058   314058

@jack7anderson7 jack7anderson7 added the PR:Community Contribution These are contribution made by the community label Dec 3, 2018
@cameronblaikie
Copy link
Contributor

Assessed 👍

@cameronblaikie cameronblaikie added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label May 23, 2019
@Mac-Rae
Copy link
Contributor

Mac-Rae commented Aug 5, 2019

Please rebase this pull request onto hotfix-7.10.x as the hotfix branch is now specifically for 7.11.x issues.

Please take a look at our contribution guidelines for more information.

@Mac-Rae Mac-Rae added the Status:Requires Updates Issues & PRs which requires input or update from the author label Aug 5, 2019
@cameronblaikie cameronblaikie removed the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Aug 14, 2019
ChangezKhan and others added 2 commits October 8, 2019 22:08
Fixed a typo in the PHPDoc, updated arrays to use the short syntax,
 updated the variable name to match coding standards and updated the
 strings to use single quotes instead of double.
@Dillon-Brown Dillon-Brown changed the base branch from hotfix to hotfix-7.10.x October 8, 2019 21:16
@Dillon-Brown Dillon-Brown removed Needs Duplicated: LTS Status:Requires Updates Issues & PRs which requires input or update from the author labels Oct 8, 2019
Copy link
Contributor

@Dillon-Brown Dillon-Brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and approved, thanks for the contribution!

@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020

CLA assistant check
All committers have signed the CLA.

@pgorod
Copy link
Contributor

pgorod commented Oct 28, 2020

@ApatheticCosmos do you know if this is used in the Google Calendar integration? I'm wondering if this change might force users to re-do their Google calendar configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants