Fix LDAP login for LDAP servers which require a full DN for binding #6773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## hotfix-7.10.x #6773 +/- ##
================================================
Coverage ? 7.31%
================================================
Files ? 3735
Lines ? 386814
Branches ? 0
================================================
Hits ? 28294
Misses ? 358520
Partials ? 0 |
jack7anderson7
added
the
PR:Community Contribution
lazka
force-pushed
the
fix-ldap-bind-full-dn
branch
from
3dcf7ac
to
ec72081
Compare
ldap_rdn_lookup() tries to bind with the username, the admin username and finally anonymously, and then gives up. If that succeeds and it finds the username it will try to bind with the username and if that fails with the full DN. In our case (Microsoft LDAP) the server only allows binding with a full DN and not anonymously, so ldap_rdn_lookup() fails and the full DN is never tried. To fix this try binding with the full DN everywhere instead of just at the end.
lazka
force-pushed
the
fix-ldap-bind-full-dn
branch
from
ec72081
to
2e5a0ae
Compare
|
|
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
2 times, most recently
from
3149dea
to
ab954a4
Compare
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
from
1609e8b
to
b06335d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ldap_rdn_lookup() tries to bind with the username, the admin username and finally
anonymously, and then gives up. If that succeeds and it finds the username it will
try to bind with the username and if that fails with the full DN.
In our case (Microsoft LDAP) the server only allows binding with a full DN and not
anonymously, so ldap_rdn_lookup() fails and the full DN is never tried.
To fix this try binding with the full DN everywhere instead of just at the end.
Motivation and Context
I'd like to use SuiteCRM with our existing LDAP server.
How To Test This
Not sure.
Types of changes
Final checklist