Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/inspections potential issues #7197

Open
wants to merge 7 commits into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

Dillon-Brown
Copy link
Contributor

Description

  • Continue misbehaviour in switch.
  • DateTime constants usage validity.
    -```file_put_contents()`` race condition.
  • 'mkdir(...)' race condition
  • Strings N-character comparison flaws
  • Substring comparison flaws
  • Fixed binary operations

Motivation and Context

  1. See PHP continue docs.
  2. DATE_ATOM should be used for compatibility with ISO-8601 instead. See docs.
  3. LOCK_EX flag should be used to prevent race condition.
  4. Fix for potential race condition when several processes are attempting to create a directory which does not yet exist.
  5. The specified length doesn't match the string length.
  6. The specified length doesn't match the string length.
  7. Fixed a variety of binary operation issues (Misplaced operators, hardcoded booleans).

How To Test This

See Travis, this should not change existing functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (hotfix-7.10.x@e56281d). Click here to learn what that means.
The diff coverage is 9.24%.

@@               Coverage Diff                @@
##             hotfix-7.10.x    #7197   +/-   ##
================================================
  Coverage                 ?    7.27%           
================================================
  Files                    ?     3694           
  Lines                    ?   385741           
  Branches                 ?        0           
================================================
  Hits                     ?    28051           
  Misses                   ?   357690           
  Partials                 ?        0

@Mac-Rae
Copy link
Contributor

Mac-Rae commented Jul 17, 2019

Assessed by Travis 👍

However, Needs conflicts sorted before merge

@Mac-Rae Mac-Rae added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Jul 17, 2019
@salesagility salesagility deleted a comment Aug 5, 2019
@codecov-commenter
Copy link

Codecov Report

Merging #7197 into hotfix-7.10.x will increase coverage by 0.00%.
The diff coverage is 14.77%.

@@              Coverage Diff               @@
##           hotfix-7.10.x    #7197   +/-   ##
==============================================
  Coverage          10.70%   10.70%           
==============================================
  Files               3229     3229           
  Lines             240902   240907    +5     
==============================================
+ Hits               25798    25799    +1     
- Misses            215104   215108    +4     

@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants