-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/inspections potential issues #7197
Open
Dillon-Brown
wants to merge
7
commits into
salesagility:hotfix-7.10.x
Choose a base branch
from
Dillon-Brown:fix/inspections_bug
base: hotfix-7.10.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/inspections potential issues #7197
Dillon-Brown
wants to merge
7
commits into
salesagility:hotfix-7.10.x
from
Dillon-Brown:fix/inspections_bug
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## hotfix-7.10.x #7197 +/- ##
================================================
Coverage ? 7.27%
================================================
Files ? 3694
Lines ? 385741
Branches ? 0
================================================
Hits ? 28051
Misses ? 357690
Partials ? 0 |
Assessed by Travis 👍 However, Needs conflicts sorted before merge |
Mac-Rae
added
the
Status:Assessed
PRs that have been tested and confirmed to resolve an issue by a core team member
label
Jul 17, 2019
code-ph0y
force-pushed
the
fix/inspections_bug
branch
from
May 29, 2020 10:46
d1903fe
to
b7c8864
Compare
Codecov Report
@@ Coverage Diff @@
## hotfix-7.10.x #7197 +/- ##
==============================================
Coverage 10.70% 10.70%
==============================================
Files 3229 3229
Lines 240902 240907 +5
==============================================
+ Hits 25798 25799 +1
- Misses 215104 215108 +4 |
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
2 times, most recently
from
October 28, 2020 17:49
3149dea
to
ab954a4
Compare
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
from
November 5, 2020 22:05
1609e8b
to
b06335d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status:Assessed
PRs that have been tested and confirmed to resolve an issue by a core team member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-```file_put_contents()`` race condition.
Motivation and Context
How To Test This
See Travis, this should not change existing functionality.
Types of changes
Final checklist