Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Record Requests In Telescope #24

Closed
wants to merge 17 commits into from

Conversation

Sammyjo20
Copy link
Collaborator

@Sammyjo20 Sammyjo20 commented Jul 22, 2022

This PR introduces a new listener which can be subscribed to so that it records requests in Laravel Telescope. The telescope entry will be recorded under the "HTTP Client" section of Telescope.

Fixes #21

Copy link
Collaborator Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review complete

phpunit.xml Outdated Show resolved Hide resolved
Copy link

@rrolla rrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic :)

@Sammyjo20
Copy link
Collaborator Author

@rrolla Any idea why these tests are failing? I'm struggling to find out how to fix it :/

@rrolla
Copy link

rrolla commented Sep 25, 2022

@rrolla Any idea why these tests are failing? I'm struggling to find out how to fix it :/

@Sammyjo20 Can you please provide more information? What's the error, how to run tests?

@rrolla
Copy link

rrolla commented Sep 26, 2022

Oh from mobile I cannot see here is github actions, I will take a look.

@rrolla
Copy link

rrolla commented Sep 26, 2022

@Sammyjo20 I would say its because of this package updates: https://github.com/ramsey/uuid/releases but I don't know which package depends on ramsey/uuid

@Sammyjo20
Copy link
Collaborator Author

Closing as this will be a v2 feature natively 🚀

@Sammyjo20 Sammyjo20 closed this Nov 18, 2022
@rrolla
Copy link

rrolla commented Nov 21, 2022

Thanks @Sammyjo20 waiting for the release :)

@Sammyjo20
Copy link
Collaborator Author

Keep an eye out on the issue for updates :)

@Sammyjo20 Sammyjo20 deleted the feature/telescope-recorder branch February 20, 2023 20:03
@Sammyjo20 Sammyjo20 restored the feature/telescope-recorder branch February 20, 2023 20:03
@Sammyjo20 Sammyjo20 deleted the feature/telescope-recorder branch September 13, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants