Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node 10 support #808

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Drop node 10 support #808

merged 2 commits into from
Jun 29, 2021

Conversation

littlewhywhat
Copy link
Contributor

By analogy with #615

@littlewhywhat littlewhywhat reopened this Jun 13, 2021
@littlewhywhat
Copy link
Contributor Author

strange... @jkotrlik could you take a look - deleted test-node-10 job but circle ci still expects it to run. Maybe because initially when I opened PR i forgot to remove https://github.com/salsita/node-pg-migrate/pull/808/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47L503-L505 and now it may be stuck

@littlewhywhat
Copy link
Contributor Author

@goce-cz decided to drop support because many deps are dropping it - see open PRs for dep updates https://github.com/salsita/node-pg-migrate/pulls?q=is%3Apr+is%3Aopen+label%3Adrop-node-10

@littlewhywhat
Drop node 10
938b7cb 
Signed-off-by: Roman Vaivod <romanv@salsitasoft.com>
goce-cz
goce-cz reviewed Jun 20, 2021
View reviewed changes
Copy link
Contributor

@goce-cz goce-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to run the tests on Node 14 - 16 since we're indirectly claiming we support only modern stack.

@littlewhywhat littlewhywhat merged commit 8579978 into master Jun 29, 2021
@littlewhywhat
Copy link
Contributor Author

Added node-16 check - all green, so I merge :) thanks 👍

@littlewhywhat littlewhywhat deleted the drop-node-10-support branch June 29, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goce-cz goce-cz goce-cz left review comments

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littlewhywhat @Shinigami92 @goce-cz