Locking migrations #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolezel
force-pushed
the
locking
branch
3 times, most recently
from
308eea3
to
21e1520
Compare
dolezel
commented
May 23, 2017
lib/runner.js
Outdated
| .then(() => db.query(`COMMENT ON TABLE "${schema}"."${options.migrations_table}" IS '${lockName}'`)) | ||
| .then(getCurrentLockName) | ||
| .then(currentLockName => { | ||
| if (currentLockName !== lockName) { |
There was a problem hiding this comment.
Now when I'm looking on it. It is not 100% lock 🤦♂️
When some other lock manages to run between first getCurrentLockName and commenting on table, we will have two locks obtained...
lib/utils.js
Outdated
|
|
||
| export const getMigrationTableSchema = options => options.migrations_schema || options.schema || 'public'; | ||
|
|
||
| export const finallyPromise = block => [ |
There was a problem hiding this comment.
Unfortunately native Promise does not have finally...
|
|
||
| export const getMigrationTableSchema = options => options.migrations_schema || options.schema || 'public'; | ||
|
|
||
| export const finallyPromise = func => [ |
There was a problem hiding this comment.
Unfortunately native Promise does not have finally...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
I found several options:
UPDATE/INSERT INTO xxx WHERE lock IS NULL) but I do not want to pollute schema with another table