New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency moment to v2.29.4 [security] #24

Open

renovate wants to merge 1 commit into master from renovate/npm-moment-vulnerability

Contributor

renovate bot commented Apr 25, 2022 •

edited

Loading

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
moment (source)	`2.18.0` -> `2.29.4`

GitHub Vulnerability Alerts

CVE-2022-24785

Impact

This vulnerability impacts npm (server) users of moment.js, especially if user provided locale string, eg fr is directly used to switch moment locale.

Patches

This problem is patched in 2.29.2, and the patch can be applied to all affected versions (from 1.0.1 up until 2.29.1, inclusive).

Workarounds

Sanitize user-provided locale name before passing it to moment.js.

References

Are there any links users can visit to find out more?

For more information

If you have any questions or comments about this advisory:

Open an issue in moment repo

CVE-2022-31129

Impact

using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic (N^2) complexity on specific inputs
noticeable slowdown is observed with inputs above 10k characters
users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks

Patches

The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.

Workarounds

In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.

References

There is an excellent writeup of the issue here: https://github.com/moment/moment/pull/6015#issuecomment-1152961973=

Details

The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process, which is unacceptable.

CVE-2017-18214

Affected versions of moment are vulnerable to a low severity regular expression denial of service when parsing dates as strings.

Recommendation

Update to version 2.19.3 or later.

Release Notes

moment/moment (moment)

`v2.29.4`

Release Jul 6, 2022
- #6015 [bugfix] Fix ReDoS in preprocessRFC2822 regex

`v2.29.3`

Release Apr 17, 2022
- #5995 [bugfix] Remove const usage
- #5990 misc: fix advisory link

`v2.29.2`

Release Apr 3 2022

Address GHSA-8hfj-j24r-96c4

`v2.29.1`

Release Oct 6, 2020

Updated deprecation message, bugfix in hi locale

`v2.29.0`

Release Sept 22, 2020

New locales (es-mx, bn-bd).
Minor bugfixes and locale improvements.
More tests.
Moment is in maintenance mode. Read more at this link:
https://momentjs.com/docs/#/-project-status/

`v2.28.0`

Release Sept 13, 2020

Fix bug where .format() modifies original instance, and locale updates

`v2.27.0`

Release June 18, 2020

Added Turkmen locale, other locale improvements, slight TypeScript fixes

`v2.26.0`

Release May 19, 2020

TypeScript fixes and many locale improvements

`v2.25.3`

Release May 4, 2020

Remove package.json module property. It looks like webpack behaves differently
for modules loaded via module vs jsnext:main.

`v2.25.2`

Release May 4, 2020

This release includes ES Module bundled moment, separate from it's source code
under dist/ folder. This might alleviate issues with finding the `./locale
subfolder for loading locales. This might also mean now webpack will bundle all
locales automatically, unless told otherwise.

`v2.25.1`

Release May 1, 2020

This is a quick patch release to address some of the issues raised after
releasing 2.25.0.

2e268635 [misc] Revert #5269 due to webpack warning
226799e1 [locale] fil: Fix metadata comment
a83a521 [bugfix] Fix typeoff usages
e324334 [pkg] Add ts3.1-typings in npm package
28cc23e [misc] Remove deleted generated locale en-SG

`v2.25.0`

Release May 1, 2020
#4611 022dc038 [feature] Support for strict string parsing, fixes #2469
#4599 4b615b9d [feature] Add support for eras in en and jp
#4296 757d4ff8 [feature] Accept custom relative thresholds in duration.humanize
18 bigfixes
36 locale fixes
5 new locales (oc-lnc, zh-mo, en-in, gom-deva, fil)

`v2.24.0`

Release Jan 21, 2019
#4338 [bugfix] Fix startOf/endOf DST issues while boosting performance
#4553 [feature] Add localeSort param to Locale weekday methods
#4887 [bugfix] Make Duration#as work with quarters
3 new locales (it-ch, ga, en-SG)
Lots of locale improvements

`v2.23.0`

Release Dec 12, 2018
#4863 [new locale] added Kurdish language (ku)
#4417 [bugfix] isBetween should return false for invalid dates
#4700 [bugfix] Fix #4698: Use ISO WeekYear for HTML5_FMT.WEEK
#4563 [feature] Fix #4518: Add support to add/subtract ISO weeks
other locale changes, build process changes, typos

`v2.22.2`

Release May 31, 2018
#4564 [bugfix] Avoid using trim()
#4453 [bugfix] Treat periods as periods, not regex-anything period, for weekday parsing in strict mode.
Minor locale improvements (pa-in, be, az)

`v2.22.1`

Release Apr 14, 2018
#4495 [bugfix] Added HTML5_FMT to moment.d.ts
Minor locale improvements
QUnit upgrade and coveralls reporting

`v2.22.0`

Release Mar 30, 2018
#4423 [new locale] Added Mongolian locale mn
Various locale improvements
Minor misc changes

`v2.21.0`

Release Mar 2, 2018
#4391 [bugfix] Fix #4390: use offset properly in toISOString
#4310 [bugfix] Fix #3883 lazy load parentLocale in defineLocale, fallback to global if missing
#4085 [misc] Print console warning when setting non-existent locales
#4371 [misc] fix deprecated rollup options
New locales: ug-cn, en-il, tg
Various locale improvements

`v2.20.1`

Release Dec 18, 2017
#4359 [locale] Fix Arabic locale for months (again)
#4357 [misc] Add optional parameter keepOffset to toISOString

`v2.20.0`

Release Dec 16, 2017
#4312 [bugfix] Fix #4251: Avoid RFC2822 in utc() test
#4240 [bugfix] Fix incorrect strict parsing with full-width parentheses
#4341 [feature] Prevent toISOString converting to UTC (issue #1751)
#4154 [feature] add format constants to support output to HTML5 input type formats (see #3928)
#4143 [new locale] mt: Maltese language
#4183 [locale] Relative seconds i18n
Various other locale improvements

`v2.19.4`

Release Dec 10, 2017
#4332 [bugfix] Fix weekday verification for UTC and offset days (fixes #4227)
#4336 [bugfix] Fix #4334: Remove unused function call argument
#4246 [misc] Add 'ss' relative time key to typescript definition

`v2.19.3`

Release Nov 29, 2017
#4326 [bugfix] Fix for ReDOS vulnerability (see #4163)
#4289 [misc] Fix spelling and formatting for U.S. for es-us

`v2.19.2`

Release Nov 11, 2017
#4255 [bugfix] Fix year setter for random days in a leap year, fixes #4238
#4242 [bugfix] updateLocale now tries to load parent, fixes #3626

`v2.19.1`

Release Oct 11, 2017

Make react native and webpack both work

#4225 #4226 #4232

`v2.19.0`

Release Oct 10, 2017

`v2.18.1`

Release Mar 22, 2017
#3853 [misc] Fix invalid whitespace character causing inability to parse
moment.js

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate bot force-pushed the renovate/npm-moment-vulnerability branch from f8eaee2 to 3df65da Compare

September 25, 2022 22:36

renovate bot changed the title ~~fix(deps): update dependency moment to v2.29.2 [security]~~ fix(deps): update dependency moment to v2.29.4 [security]


          fix(deps): update dependency moment to v2.29.4 [security]

10d56d5

renovate bot force-pushed the renovate/npm-moment-vulnerability branch from 3df65da to 10d56d5 Compare

November 14, 2022 19:37

renovate bot changed the title ~~fix(deps): update dependency moment to v2.29.4 [security]~~ Update dependency moment to v2.29.4 [SECURITY]

renovate bot changed the title ~~Update dependency moment to v2.29.4 [SECURITY]~~ fix(deps): update dependency moment to v2.29.4 [security]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet