This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
Fix re-auth hang. #181
Merged
Fix re-auth hang. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunxiangHuang
force-pushed
the
reauth
branch
from
7ac3585
to
401c70b
Compare
|
Thanks a lot @YunxiangHuang for submitting it! We were also hit by this bug. CI seems to fail though - do you think you could have a look at it? |
This was referenced Jan 29, 2018
Closed
|
Hey @YunxiangHuang , thanks for fixing this bug. We've been hit by this bug as well. I've tried to run test in this patch but it wasn't passing race condition detector. I've fixed race bugs in mesosphere#1 . Please feel free to cherry-pick changes to get your tests passing. You'll also need changes from #184 to get CI working. |
jeffbean
pushed a commit
to jeffbean/go-zookeeper
that referenced
this pull request
Dec 28, 2018
* Add test for recurring re-authing hang * Fix re-authing hang
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lose zk connection while re-send zk auth caused send loop always waiting for reauth finish.
May have better way to recurring the problem.