change property unit tests to assert against real DOM #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
ro0gr
commented
Aug 29, 2017
| @@ -258,24 +234,6 @@ moduleForProperty('clickOnText', function(test) { | |||
| }, /page\.foo\.bar\.baz\.qux/, 'Element not found'); | |||
| }); | |||
|
|
|||
| test("doesn't raise an error when the element is not visible and `visible` is not set", function(assert) { | |||
ro0gr
commented
Aug 29, 2017
| let name = template.substr(1, gtPos - 1); | ||
| const [tagName, attrName] = name.split(' '); | ||
|
|
||
| test(`looks for ${tagName} with ${attrName}`, function(assert) { |
There was a problem hiding this comment.
need to figure out how to simplify [contenteditable], input, textarea, select tests
|
Thanks for simplify the test @ro0gr |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current approach for testing properties doesn't scale very well. For example it's impossible to run existing properties tests against alternative contexts like native contexts.
The general idea of this pr is changing assertions like
to
This way we don't test internals of contexts anymore.
@san650 There is some work left to do here(mostly cleanup). Anyway I would appreciate your thoughts on this change. Does this approach make sense to you?