Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native-dom mode documentation #334

Closed
wants to merge 5 commits into from
Closed

Conversation

ro0gr
Copy link
Collaborator

@ro0gr ro0gr commented Oct 18, 2017

I guess we're gonna to release native-dom mode in 1.13 so I've copy-pasted pages from v1.12.x to v1.13.x.

Also a simple page describing why do we need ember-native-dom-helpers and how to enable it was added.

I'm open for any suggestions on re-phrasing or any improvements of the new page cause I'm not very good in gluing the words 😄

topics to cover:

@ro0gr ro0gr mentioned this pull request Oct 18, 2017
11 tasks
@ro0gr
Copy link
Collaborator Author

ro0gr commented Oct 18, 2017

tbh I haven't ruby installed locally 🙊 ... so I haven't tested it yet.
I'm curious if there is a way to test resulting docs instantly?

@@ -0,0 +1,28 @@
---
layout: page
title: Native DOM Helpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest Triggering Native vs. jQuery DOM Events as the title of this page. Would be nice to have something as expressive as possible so that people can easily realize "oh, yeah...that sounds like what I'm dealing with."

Copy link
Collaborator Author

@ro0gr ro0gr Nov 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's a good direction. I'm finally agreed with you that the key thing here are Events

@san650 san650 self-assigned this Oct 29, 2017
@ro0gr
Copy link
Collaborator Author

ro0gr commented Nov 18, 2017

from slack by @magistrula

in jquery event mode isVisible returns false for an empty div, but in native event mode, isVisible returns true for an empty div.

@magistrula
Copy link
Contributor

@ro0gr I'm going to close this PR, since these documentation updates were handled in this week's release. Thanks for supplying the initial draft of the documentation for native-events mode!

@magistrula magistrula closed this Jan 11, 2018
@ro0gr ro0gr deleted the native-dom-mode-doc branch May 13, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants