Refactored collatz_eval to get rid of list. This implementation still…

… gets wrong answer (WA) on Sphere
sandan · Jun 15, 2014 · 3c282b2 · 3c282b2
1 parent 47915d8
commit 3c282b2
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/SphereCollatz.py b/SphereCollatz.py
@@ -37,12 +37,15 @@ def collatz_eval (i, j) :
     """
     # <your code>
     c_len=0
-    end=j+1
     result=0
-    for num in range(i,end):
-        result=cycle_length(num)
-        if c_len < result:
+    k=max(i,j)
+    i=min(i,j)
+
+    while( k >= i):
+        result=cycle_length(k)
+        if (c_len < result) :
             c_len=result
+        k-=1
 
     return c_len