Remove unnecessary null pointer checks

[elfring]

An extra null pointer check is not needed in functions like the following.

• CAnimatedBitmap::SetImage
• CBoxProc
• CMessageDialog

[DavidXanatos]

meh... you cave a comparison but than you assign a null pointer null again and have a unnecessary call to free.
if we know that statistically the variables are mostly == 0 than yea that would optimize things, but currently idk. so without the comparison we may end up with waiting more CPU cycles in the end.

Anyhow such minor optimizations are something for much later imho.

[elfring]

• Which distribution would you expect (or actually observe) for the passing of null pointers?
• Should pointers for valid objects be usually handled more often?

---

How do you think about to use a development tool like “clang-tidy” for corresponding source code adjustments?

[DavidXanatos]

I never payed attention to that so idk.