Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean translation (Sandboxie Plus) #2133

Merged
merged 14 commits into from
Aug 16, 2022
Merged

Add Korean translation (Sandboxie Plus) #2133

merged 14 commits into from
Aug 16, 2022

Conversation

VenusGirl
Copy link
Contributor

Thank you for your contribution to the Sandboxie repository.

In order to reduce the risk of accidental merges, it's highly recommended for beginners to open a new Pull Request in draft state by clicking the button "Create Draft Pull Request", instead of using the default "Create Pull Request" option.

In addition, you can convert an existing pull request to a draft by clicking the "Convert to draft" link in the right sidebar under "Reviewers".

All new translators are encouraged to look at the "Localization notes and tips" before creating a pull request: https://git.io/J9G19

Copy link
Collaborator

@isaak654 isaak654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other dependencies to translate / add:

  • 1. Here you can find the location of the Sandboxie Plus installer languages file where you need to translate the english lines in the [CustomMessages] section

  • 2. Here you can find the location of the Sandboxie Plus installer script where you need to add the language value, for example: 'korean': Result := 'ko';

  • 3. Upload the Korean unofficial language for InnoSetup in our custom ISL folder

  • 4. Add Name: "korean"; MessagesFile: "isl\Korean.isl" in the [Languages] section of Languages.iss

SandboxiePlus/SandMan/sandman_ko.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@isaak654 isaak654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a rule of thumb, you shouldn't ever translate the .ts files by hand, in order to avoid formatting issues (the use of an official translation tool like Qt Linguist is highly recommended).

Just in case, please take a look at the recommendations chapter in the Localization notes and tips: https://git.io/J9G19

@isaak654 isaak654 added incorrect This doesn't seem done right Work in progress Still in progress labels Aug 14, 2022
@isaak654 isaak654 marked this pull request as draft August 14, 2022 17:09
Copy link
Collaborator

@isaak654 isaak654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this rate we will not make it, please use the official Linguist tool described in the previous guide to check all errors at once instead to wait the reviews one by one (there are more than 5000 lines in sandman_ko.ts).
Once loaded the TS file, the tool will indicate you the entries to fix. It will also help you to prevent any type of formatting issue in future.

EDIT: Explained better in #2133 (review)

SandboxiePlus/SandMan/sandman_ko.ts Outdated Show resolved Hide resolved
@isaak654 isaak654 mentioned this pull request Aug 14, 2022
Copy link
Collaborator

@isaak654 isaak654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We're almost there, now you need to open the TS file. You will see this:

linguist_pic

  • 1. the esclamation marks in red mean that some element of punctuation is missing. (fixed with 2faa51b)
  • 2. the questions marks in yellow mean that you need to mark the translated entries as finished: (fixed with cde0a47)
    entry_marked_as_finished
    You can leave some of the entries of which you have doubts as unfinished, but not to leave all entries as unfinished at 100%.
    As example, see the animated video below (you can open it in a new tab to restart it):
    How_to_mark_finished_translations_in_Linguist
    Feel free to decide the number of entries you want to mark.

@VenusGirl VenusGirl marked this pull request as ready for review August 15, 2022 02:37
@isaak654
Copy link
Collaborator

👉 #2133 (review) (updated)

@isaak654 isaak654 marked this pull request as draft August 15, 2022 06:41
@isaak654 isaak654 mentioned this pull request Aug 15, 2022
@isaak654
Copy link
Collaborator

If you have doubts about the remaining task in #2133 (review), I am available for any clarification.

@VenusGirl
Copy link
Contributor Author

#2143 is a correction of all the missing translations, incorrect translations, and recently changed digit position changes in #2133.

I reviewed it with linguist.exe, and all of them are marked with a yellow question mark.

@VenusGirl
Copy link
Contributor Author

샌드 번역

@isaak654
Copy link
Collaborator

isaak654 commented Aug 16, 2022

  1. The sandman_ko.ts file in Create sandman_ko.ts #2143 was identical to the one in this PR, I verified it with the comparison tool WinMerge. But let's say it wasn't, it is better to work on it in one place here.
  2. I just uploaded an animated video at the bottom of this comment in order to show you how to mark unfinished entries as finished. I hope it's clear now, I think it is useful to distinguish finished entries from unfinished ones.

@VenusGirl
Copy link
Contributor Author

샌드박스

@isaak654 isaak654 marked this pull request as ready for review August 16, 2022 07:22
@isaak654 isaak654 added Localization Localization/translation issues and removed incorrect This doesn't seem done right Work in progress Still in progress labels Aug 16, 2022
@isaak654 isaak654 changed the title Create sandman_ko.ts Add Korean translation Aug 16, 2022
Copy link
Collaborator

@isaak654 isaak654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged, just waiting the CI to be fixed:
GitHub Build Status

@DavidXanatos Make sure to not incur in #1556 after this PR will be merged.

@isaak654 isaak654 merged commit 012bd62 into sandboxie-plus:master Aug 16, 2022
@VenusGirl
Copy link
Contributor Author

Thank you for your help and thank you for your hard work.

@isaak654
Copy link
Collaborator

You're welcome.

If you are looking for other ways to contribute:

  1. you may want to update Text-Korean-1042.txt that is meant to contain both Classic & Plus entries for compatibility reasons.
    In order to facilitate the task, I restored a reporting script that periodically lists the new entries that should be added, translated or commented out: Report-Korean.txt

  2. unfortunately I'm not aware of a clear method to autocommit/sync the new additions from Report-Korean.txt to Text-Korean-1042.txt. Just in case, here are the interested scripts:

@isaak654 isaak654 changed the title Add Korean translation Add Korean translation (Sandboxie Plus) Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Localization/translation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants