Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean.isl - Update encoding #2173

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Korean.isl - Update encoding #2173

merged 4 commits into from
Aug 22, 2022

Conversation

VenusGirl
Copy link
Contributor

Changing the encoding because there was a problem with Korean not being displayed properly when installation

샌드박스 설치

@isaak654 isaak654 changed the title Korean.isl - Update Korean.isl - Update encoding Aug 21, 2022
@isaak654
Copy link
Collaborator

Fair enough, but the line ending should be the same of the other .isl files (LF).

@isaak654
Copy link
Collaborator

I think this should be properly tested by @DavidXanatos before merging, otherwise we risk running in circles.

@DavidXanatos
Copy link
Member

if this looks right:
grafik

then the PR can be merged

@isaak654 isaak654 removed the request for review from DavidXanatos August 21, 2022 20:39
@VenusGirl
Copy link
Contributor Author

Now I can see the Korean language correctly.

@DavidXanatos DavidXanatos merged commit 200bfff into sandboxie-plus:master Aug 22, 2022
isaak654 added a commit that referenced this pull request Aug 22, 2022
As the Chinese .isl files: #2173
@DavidXanatos
Copy link
Member

I just saw the current 1.3.2 installer is missing the fix, a new one will be provided soon

@VenusGirl
Copy link
Contributor Author

Yes!

When installing sandboxie-plus, it is not displayed properly due to a Korean.isl encoding problem.

If you ignore it and continue installing it, sandboxie-plus will run normally, but shortcuts will not be created properly.

sinstall 001
sinstall 002
sinstall 003

@DavidXanatos
Copy link
Member

fixed installer uploaded please test

@VenusGirl
Copy link
Contributor Author

sandInstall01
sandinstall02

All are now well displayed when you install it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants