Clean up the invalid values that do not exist for m_Collapsed #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaak654
changed the title
|
not only groups can be collapsed but also boxes so the check must check for boxes and groups |
isaak654
changed the title
|
It occurred to me that the QStringList stored in m_Group contains the names of the group and the box. By eliminating the non-existent values from m_Collapsed in m_Group, the check is done for both the box and the group. Am I missing anything else? |
|
In fact, another omission here is used to clean up invalid Box names in m_Group. |
Clean up the invalid Box names in BoxDisplayOrder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last change, it will clean up the invalid values that do not exist in m_Groups for m_Collapsed.