fix behaviour on multiple selection #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the first simpler one sounds more intuitive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should have been resolved now, and I haven't encountered any other issues locally for the time being. The two patches implement different behaviors. One of them prevents all selected items from moving further when the current position reaches a boundary, while the other terminates individually only when a boundary is reached within each group. I'm not sure which option to choose.
Patch1 (This PR)
0001-fix-behaviour-on-multiple-selection.patch
Patch2
0002-fix-behaviour-on-multiple-selection.patch