Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed German spelling for Text-German-1031.txt #402

Closed
wants to merge 1 commit into from
Closed

Fixed German spelling for Text-German-1031.txt #402

wants to merge 1 commit into from

Conversation

NewKidOnTheBlock
Copy link
Contributor

There was a warning message though:
"We’ve detected the file encoding as UTF-16LE. When you commit changes we will transcode it to UTF-8."

There was a warning message though:
"We’ve detected the file encoding as UTF-16LE. When you commit changes we will transcode it to UTF-8."
@isaak654
Copy link
Collaborator

isaak654 commented Jan 19, 2021

There was a warning message though:
"We’ve detected the file encoding as UTF-16LE. When you commit changes we will transcode it to UTF-8."

It means that this commit is broken, and if it will be merged (as it is now), it will break the german translation too.

It happened to me as well, please read here: #264

@NewKidOnTheBlock
Copy link
Contributor Author

NewKidOnTheBlock commented Jan 19, 2021

I can't find a way to switch Notepad++ to UTF16 LE.
Closing.

@NewKidOnTheBlock
Copy link
Contributor Author

Okay, I have no clue how this is supposed to work.
The second I click the edit button, Github notifies me that it's gonna destroy the coding by converting it from UTF16LE to UTF8.
And there's no other way to edit the file.

@DavidXanatos
Copy link
Member

Download it on your HDD use a tool like Tortois SVN edit it locally and commit the changes

@isaak654
Copy link
Collaborator

isaak654 commented Jan 19, 2021

I can't find a way to switch Notepad++ to UTF16 LE.
Closing.

@NewKidOnTheBlock
In Notepad++, UTF16 LE is UCS-2 LE BOM. You should keep that encoding without changing it.

These are the complete steps to follow:

  1. You should download the file you want from the repo, in order to edit it locally in your Windows pc (i.e. here, right click on RAW button -> save file as).
  2. Use Notepad++ to perform the changes (keeping the odd UCS-2 LE BOM encoding).
  3. Create a new fresh fork and go there, to the path where you want to update the file (i.e. here) and upload the translated file there using the "Add file" -> "Upload files" function (see my attachment). In this way you will bypass the online editor conversion.
  4. Choose your file(s) to upload on the upper screen (drag&drop doesn't work for me), put a title to your commit and select the option "Commit directly to the master branch".
  5. You will be redirected on your main forked repo. Now click on "Pull request" button (under Add file button).
  6. Now you can create the pull request that will be posted directly in sandboxie-plus/Sandboxie.

image

P.S: I'm assuming that @DavidXanatos is using a Linux distribution, and this online editor issue appears when you use the feature in a Windows OS.

@NewKidOnTheBlock
Copy link
Contributor Author

NewKidOnTheBlock commented Jan 20, 2021

@isaak654
Thanks for the detailed explanation.
I think I was able to pull it off on the umpteenth try.

I'd still say that converting all .txts to UTF-8 would make everyone's life easier.
It would also add the benefit of being able to see the diffs directly without downloading 2 files and running the comparison manually.

@DavidXanatos
Copy link
Member

P.S: I'm assuming that @DavidXanatos is using a Linux distribution, and this online editor issue appears when you use the feature in a Windows OS.

No I would be using linux I would not work on tools for windows.

I just don't use gits onlien editors but Notepad2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants