Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed orthography in sandman_de.ts #406

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Fixed orthography in sandman_de.ts #406

merged 1 commit into from
Jan 19, 2021

Conversation

NewKidOnTheBlock
Copy link
Contributor

@NewKidOnTheBlock NewKidOnTheBlock commented Jan 19, 2021

Two things to note:

  1. I've deleted all instances of <oldsource>
  2. @DavidXanatos At one point, you have to decide how SandboxiePlus is supposed to be spelled officially:
    a) Sandboxie Plus (~a handful of instances)
    b) SandboxiePlus (~a dozen instances)
    c) Sandboxie-Plus (~50 instances)

To establish congruity, I've converted all occurrences of a) & b) --> c) in this edit.

Two things to note:
1.) I've deleted all instances of "oldsource"
2.) @DavidXanatos At one point, you have to decide how SandboxiePlus is supposed to be spelled:
a) Sandboxie Plus? (~a hand-full of instances)
b) SandboxiePlus? (~a dozen instances)
c) Sandboxie-Plus? (~50 instances)

To establish congruity, I've opted for c) in my edit.
@DavidXanatos DavidXanatos merged commit 1e17b36 into sandboxie-plus:master Jan 19, 2021
@NewKidOnTheBlock
Copy link
Contributor Author

NewKidOnTheBlock commented Nov 8, 2022

@DavidXanatos
What is the official spelling?
It keeps contradicting itself; very often on the same page.
RRRAAAH
RRRAAAH2

@isaak654
Copy link
Collaborator

This pull request has certainly aged badly, the direct edit of <source> strings in .ts files is to avoid completely, unless you also edit the respective source files.

See this note from the Localization notes:

⚠️ You shouldn't ever edit the text in the source tags of the .ts file if you don't apply the same edit on the respective source code file. For example, see the following commit: 3b86441.

See also my reply in the Slack channel:

Updating sandman_en.ts is not a feasible option, because that file is based on the source files (which are the only ones you should update as minimum).
Once those are updated, the lupdate workflow takes care of updating all the .ts files every night through a schedule.
However, the manual removal of <oldsource> references might be OK.

@NewKidOnTheBlock
Copy link
Contributor Author

NewKidOnTheBlock commented Nov 23, 2022

Understood. The .ts files are auto-generated and shouldn't be touched as they get their values from somewhere else.

This leaves the question what should be edited instead.
The main goal of my 2-hour editing session was to fix the word capitalisation in the Sandboxie Plus options.
I fine-combed through every single tab.

Just have look, this is a user's first impression of the SB Plus options:
capitalisation is all over the place
The orthgraphy is alright, but tHe CaPitAlisAtION is all over the place, often contradicting itself.

@isaak654
Copy link
Collaborator

Those entries are part of SettingsWindow.ui, however, when there are .ui files to fix in the middle, it would be highly recommended to report them directly to @DavidXanatos.

I remember a lot of typos in .ui files already fixed in pull requests but suddenly restored. Apparently there are some synchronisation issues with .ui files in the Qt environment from which David creates the builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants