Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Khatrirao cleanup #127

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Khatrirao cleanup #127

merged 3 commits into from
Jun 3, 2023

Conversation

ntjohnson1
Copy link
Collaborator

I was looking at our khatrirao implementation and realized it needed a little TLC. This is a small PR:

  1. Remove debug prints (could leave them in place a logs at a debug level so they can be turned back on in the future but I assume for now can just prune)
  2. Update interface to only take repeated matrices to simplify
  3. Add linting and typing to improve our coverage and also to validate everything matches the new interface. Since a lot of our core tensors already have types this immediately pointed out incorrect usages just based on types.
  4. We had special cased things based on the value of ncols_first but that doesn't actually look like it is required

* Simplify interface to only take repeated matrices
* Update all uses
* Add test to clearly highlight users of the old interface
@ntjohnson1 ntjohnson1 marked this pull request as ready for review June 3, 2023 16:10
@ntjohnson1 ntjohnson1 requested a review from dmdunla June 3, 2023 16:10
@dmdunla dmdunla merged commit d70a102 into sandialabs:main Jun 3, 2023
@ntjohnson1 ntjohnson1 deleted the khatrirao_cleanup branch June 3, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants