Coveralls: Try updating to default suggestion #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I understand correctly the issues we were seeing before had to do with the coveralls github action and package itself rather than any of our source code. I still think it is probably good practice for us to have a little more specificity on our pacakage dependencies but that doesn't appear to be the cause of the bug we saw with our coverage |
dmdunla
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the coveralls python package suggestion here seems to resolve our issues with weird coverage in our github action. https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support
NOTE: Do we use the sphinx_rtd_theme anywhere for our current testing/deployment? I don't think so. If we do we should probably update our automation to
pip install .[dev,doc]instead of manually specifiying the theme (manually specifying coveralls since that is only for the action makes sense still). But that's more energy than I have for this tonight.