Dynamic topology phase IV #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokusanya
commented
Aug 15, 2024
gsjaardema
requested changes
Aug 15, 2024
packages/seacas/libraries/ioss/src/unit_tests/UnitTestDynamicTopology.C
Outdated
Show resolved
Hide resolved
gsjaardema
requested changes
Aug 19, 2024
packages/seacas/libraries/ioss/src/exodus/Ioex_BaseDatabaseIO.C
Outdated
Show resolved
Hide resolved
gsjaardema
reviewed
Aug 27, 2024
gsjaardema
requested changes
Sep 9, 2024
gsjaardema
reviewed
Sep 10, 2024
gsjaardema
reviewed
Sep 10, 2024
gsjaardema
reviewed
Sep 10, 2024
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.9.1 to 2.10.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@5c7944e...446798f) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* EXODUS: Add support for lossy compression via netCDF quantize method * IOSS: Add support for lossy compression specifying NSD for netCDF quantize method * EXODUS: Update version date * EXODUS: Add some error checking on nsd values * EXODUS: Check if Quantization supported; include in config output * EXODUS: Cleaning up new compression support * EXODUS: Fix error handling code * EXODUS: Better error checking on compression * IOSS: Support for zstd compression * IOSS: Handle building with no netCDF-4 capability * IOSS: Change gold files to netcdf-3 so work without hdf5-supported netCDF * CI: See if can figure out intel build failure * CI: Fix hdf5 version warning message * CI: Turn on plugins; support new syntax * EXODUS: Only flush stderr if written to Signed-off-by: Greg Sjaardema <gdsjaar@sandia.gov> * Tweak compression additions * CI: Fix intel build script syntax error * EXODUS: Support new netCDF with changed _FillValue * IOSS: Fix so latest fmt version works * IOSS: Catalyst API 2 (sandialabs#463) * IOSS: Catalyst API 2 Added support to database for using my_processor and processor_count IOSS properties when operating in serial parallel mode and reading Conduit files. * IOSS: Catalyst API 2 Changed Conduit serial parallel test to use files from the one MPI rank can.ex2 test. --------- Co-authored-by: Greg Sjaardema <gsjaardema@gmail.com> * Fix export symbols (sandialabs#465) * IOSS: Catalyst API 2 (sandialabs#466) Create the cell_ids and cell_node_ids fields for a StructuredBlock when asked for by a reading application, if these fields are not already stored in the Conduit data. Uses the get_cell_ids() and get_cell_node_ids() methods on StructuredBlock. * CI: Remove hdf5-1.8 testing * IOSS: Catalyst API 2 (sandialabs#463) * IOSS: Catalyst API 2 Added support to database for using my_processor and processor_count IOSS properties when operating in serial parallel mode and reading Conduit files. * IOSS: Catalyst API 2 Changed Conduit serial parallel test to use files from the one MPI rank can.ex2 test. --------- Co-authored-by: Greg Sjaardema <gsjaardema@gmail.com> * NEM_SPREAD: Add missing include file * CI: Enable netCDF quantize option * CI: Support newest netCDF; fmt * Enable new compression options * EXODUS: Fix non-hdf5 build * EXODUS: Do not commit the kluge to repository * IOSS: See if can fix spack ci build * CI: Spack build should not run on PR * CI: Spack build on master only [ci skip] * CI: Fix spack workflow syntax [ci skip] * IOSS: Add progress output to chain/face generation * IOSS: Reduce Face memory * EXODUS: Better control over exodus verbosity * EXODUS:, IOSS: Add bzip2 compression support * Further testing of non-lossy compression with plugins * CI: Update cmake-sems to work with current sems * Default netcdf should be 4.9.2 Signed-off-by: Greg Sjaardema <gsjaardema@gmail.com> * Clean up copyright dates Signed-off-by: Greg Sjaardema <gsjaardema@gmail.com> * Clean up copyright dates Signed-off-by: Greg Sjaardema <gsjaardema@gmail.com> * accidentally added to pr; removed Signed-off-by: Greg Sjaardema <gsjaardema@gmail.com> --------- Signed-off-by: Greg Sjaardema <gdsjaar@sandia.gov> Signed-off-by: Greg Sjaardema <gsjaardema@gmail.com> Co-authored-by: Greg Sjaardema <gdsjaar@sandia.gov> Co-authored-by: tjotaha <tjotaha@sandia.gov> Co-authored-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>
tokusanya
force-pushed
the
DynamicTopology-PhaseIV
branch
from
d939b3a
to
dfa841c
Compare
|
@gdsjaar I have removed the draft status and marked it for review ... let me know if there is still anything required |
gsjaardema
reviewed
Oct 1, 2024
packages/seacas/libraries/ioss/src/exodus/Ioex_BaseDatabaseIO.C
Outdated
Show resolved
Hide resolved
packages/seacas/libraries/ioss/src/exodus/Ioex_BaseDatabaseIO.h
Outdated
Show resolved
Hide resolved
gsjaardema
reviewed
Oct 3, 2024
| @@ -43,17 +43,39 @@ int file_exists( const Ioss::ParallelUtils &util, | |||
| return file.parallel_exists(util.communicator(), message); | |||
| } | |||
|
|
|||
| bool internal_decomp_specified(const Ioss::PropertyManager& props) | |||
| std::string get_decomposition_property(const Ioss::PropertyManager &properties, | |||
There was a problem hiding this comment.
That looks good. At some point we maybe move to the Ioss::Utils class to avoid the code dupication, but good for now.
gsjaardema
approved these changes
Oct 3, 2024
Signed-off-by: Greg Sjaardema <gsjaardema@gmail.com>
I think this is the correct change (deleting this block of code) since `handle_output_file` is returning a `m_exodusFilePtr` and sets`m_groupName`, so that is redundant with calling `ex_get_group_id` and even worse, `ex_get_group_id` is looking for a child group of itself... I'm not sure whether the code in this block is needed for an input file though...
|
@tokusanya Can you take a look at my latest commit and see if it makes sense. (The ifdef'd code would be completely removed in the final; just left it there so easier to see what was there... |
|
@gdsjaar I think I see what is happening ... the code I put in to automatically open up the first child group in |
Yes, and when I put in code that zero'd out the file pointer if the change group call failed, it then caught the error which was always happening, but just using the old file pointer... |
Remove code commented out in last commit.
|
@tokusanya I am good with you merging whenever you feel that it is ready. You should have permission to merge. |
Ok, I'm working on one last issue that might involve a quick commit |
Signed-off-by: Greg Sjaardema <gsjaardema@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality for reduction operations on groups