Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the event loop as an optional parameter to app.run(..) #64

Closed
blakev opened this issue Oct 18, 2016 · 2 comments
Closed

Expose the event loop as an optional parameter to app.run(..) #64

blakev opened this issue Oct 18, 2016 · 2 comments

Comments

@blakev
Copy link
Contributor

blakev commented Oct 18, 2016

Since the event loop is created in server.serve it could be beneficial to expose passing a pre-allocated event loop that could be used before the server starts to enable database connections and such.
blakev pushed a commit to blakev/sanic that referenced this issue Oct 18, 2016
Exposes loopin sanic serve and run functions (sanic-org#64)
edc49f5
blakev pushed a commit to blakev/sanic that referenced this issue Oct 18, 2016
Exposes loopin sanic serve and run functions (sanic-org#64)
5e459cb
channelcat added a commit that referenced this issue Oct 19, 2016
@channelcat
Merge pull request #65 from blakev/feature/expose-loop
2903e7e 
Exposes `loop`in sanic `serve` and `run` functions (#64)
@jackfischer
Copy link
Contributor

Strongly +1 this, I think it could make nice designs much more straightforward.

@channelcat
Copy link
Contributor

Merged, closing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@channelcat @blakev @jackfischer