-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to Multiplexer and Manager to terminate durable workers #2913
Conversation
…e_worker method to WorkerManager
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
=============================================
- Coverage 88.039% 87.892% -0.148%
=============================================
Files 94 94
Lines 7433 7450 +17
Branches 1283 1287 +4
=============================================
+ Hits 6544 6548 +4
- Misses 622 632 +10
- Partials 267 270 +3 ☔ View full report in Codecov by Sentry. |
|
worker = self.durable.get(ident) | ||
if not worker: | ||
error_logger.error( | ||
"Durable worker termination failed (%s not found).", worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be , ident
; not , worker
. That seems to be what's making the test fail.
I had a usecase for this in a project I'm working on and I thought it might be useful. Happy to make any changes to be more in-line with the existing codebase or planned trajectory.