Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the .message field on exceptions non-empty #2947

Merged
merged 8 commits into from
Jun 22, 2024
Merged

Make the .message field on exceptions non-empty #2947

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
464fedb
Make the `.message` field on exceptions non-empty
ekzhang May 6, 2024
a2c7c8d
Type error?
ekzhang May 6, 2024
ad45554
Normalize bytes objects to str
ekzhang May 6, 2024
7901b2c
Update exceptions.py
ekzhang May 6, 2024
d7ed99c
Try to fix type inference?
ekzhang May 6, 2024
aa27518
Merge branch 'main' of github.com:sanic-org/sanic into pr2947
ahopkins Jun 22, 2024
b16c26a
Handle new logic staying closer to original intent
ahopkins Jun 22, 2024
9084a74
Merge branch 'main' into ekzhang/sanic-message-attribute
ahopkins Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update exceptions.py
  • Loading branch information
@ekzhang
ekzhang committed May 6, 2024
commit 7901b2c45c566293faafb1a7c7032fb20a86e2fc
4 changes: 2 additions & 2 deletions sanic/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ def __init__(
)
quiet = quiet or getattr(self.__class__, "quiet", None)
headers = headers or getattr(self.__class__, "headers", {})
if not isinstance(message, str):
# If a `bytes`-like object is provided, normalize it to a string.
if isinstance(message, bytes):
# If a `bytes` object is provided, normalize it to a string.
message = message.decode("utf8")
if message is None:
cls_message = getattr(self.__class__, "message", None)
Expand Down
Loading