Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not to remove entity headers for 412 responses #2951

Closed

Conversation

ChihweiLHBird
Copy link
Member

Resolves #2575

There seems to be not a reason to remove the entity headers for 412 responses, and the removal is causing the client-side timeout error.

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner June 4, 2024 08:02
@ChihweiLHBird ChihweiLHBird force-pushed the zhiwei/not-to-remove-entity-headers-for-412 branch from bc1c0e5 to 524ebf5 Compare June 22, 2024 23:43
@ahopkins
Copy link
Member

We made this change in the LTS already, so I pulled that commit into main in #2962.

@ahopkins ahopkins closed this Jun 23, 2024
@ChihweiLHBird ChihweiLHBird deleted the zhiwei/not-to-remove-entity-headers-for-412 branch June 24, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raising a 412 on a Sanic handler causes a wait period and maybe a ReadTimeout exception on clients
2 participants