Remove unused parameter hide_recipients

hide_recipients parameter is not used. We simplify gem
functionality by removing it. Related tests are also removed.

app/mailers/spree/to_friend_mailer.rb

@@ -7,12 +7,7 @@ def mail_to_friend(object, mail)
     @mail = mail
     opts = {}
 
-    if mail.hide_recipients
-      opts[:to]  = mail.recipients.first
-      opts[:bcc] = mail.recipients[1..-1] if mail.recipients.size > 1
-    else
-      opts[:to] = mail.recipients
-    end
+    opts[:to] = mail.recipients
     default_url_options[:host] = mail.host
     opts[:subject] =  mail.subject
     opts[:reply_to] = mail.sender_email

app/models/spree/mail_to_friend.rb

@@ -1,7 +1,7 @@
 class Spree::MailToFriend
   include ActiveModel::Validations
   include ActiveModel::Conversion
-  attr_accessor :host, :subject, :sender_name, :sender_email, :recipient_name, :recipient_email, :message, :recipients, :invalid_recipients, :hide_recipients
+  attr_accessor :host, :subject, :sender_name, :sender_email, :recipient_name, :recipient_email, :message, :recipients, :invalid_recipients
 
   EMAILREGEX = /\A[-a-z0-9_+\.]+\@([-a-z0-9]+\.)+[a-z0-9]{2,8}\z/i
 
@@ -31,7 +31,6 @@ def initialize(opts = {})
     @recipient_name = opts[:recipient_name]
     @recipient_name ||= @recipients[0].split('@', 2)[0].titleize unless @recipients.empty?
 
-    @hide_recipients = opts[:hide_recipients] || false
     @message = opts[:message]
   end
 

spec/factories/mail_factory.rb

@@ -10,7 +10,6 @@
     message            'Its totally awesome..'
 
     recipients         { Array(1..4).sample.times.map{ Faker::Internet.email } }
-    hide_recipients    { [true,false].sample }
     invalid_recipients []
   end
 end

spec/mailers/to_friend_mailer_spec.rb

@@ -4,15 +4,15 @@
   let!(:product) { create(:product) }
 
   context 'mail content' do
-    let(:mail_object) { build(:mail, hide_recipients: true) }
+    let(:mail_object) { build(:mail) }
     let(:email)       { Spree::ToFriendMailer.mail_to_friend(product, mail_object) }
 
     it 'is reply to the sender email' do
       expect(email).to reply_to(mail_object.sender_email)
     end
 
-    it 'is delivered to the recipient email' do
-      expect(email).to deliver_to(mail_object.recipients.first)
+    it 'is delivered to the recipients' do
+      expect(email).to deliver_to(mail_object.recipients)
     end
 
     it 'have the correct subject' do
@@ -35,28 +35,4 @@
       expect(email).to have_body_text(spree.product_path(product))
     end
   end
-
-  describe 'using hide recipients option' do
-    context 'when true' do
-      let(:mail_object) { build(:mail, recipients: ["sue@yahoo.com", "bill@yahoo.com", "john@yahoo.com"], hide_recipients: true) }
-      let(:email)       { Spree::ToFriendMailer.mail_to_friend(product, mail_object) }
-
-      it 'include them in bcc' do
-        expect(email).to reply_to(mail_object.sender_email)
-        expect(email).to deliver_to('sue@yahoo.com')
-        expect(email).to bcc_to('bill@yahoo.com', 'john@yahoo.com')
-      end
-    end
-
-    context 'when false' do
-      let(:mail_object) { build(:mail, recipients: ["sue@yahoo.com", "bill@yahoo.com"], hide_recipients: false) }
-      let(:email)       { Spree::ToFriendMailer.mail_to_friend(product, mail_object) }
-
-      it 'should not include bcc' do
-        expect(email).to reply_to(mail_object.sender_email)
-        expect(email).to deliver_to('sue@yahoo.com', 'bill@yahoo.com')
-        expect(email).to bcc_to([])
-      end
-    end
-  end
 end