Merge pull request #25 from sansible/GITHUB-24-fix-set-fact-string-co…

…nditionals

[GITHUB-24] Fixes set fact and conditionals

defaults/main.yml

@@ -22,8 +22,8 @@ sansible_kafka_default_replication_factor: 1
 sansible_kafka_group: kafka
 sansible_kafka_heap_opts: "-Xmx{{ (ansible_memtotal_mb / 2) | int }}m -Xms{{ (ansible_memtotal_mb / 2) | int }}m"
 sansible_kafka_id: 1
-sansible_kafka_interface_advertise: no
-sansible_kafka_interface_bind: no
+sansible_kafka_interface_advertise: ~
+sansible_kafka_interface_bind: ~
 sansible_kafka_java_vendor: openjdk
 sansible_kafka_java_version: 8
 sansible_kafka_jmx_port: 9999

tasks/configure.yml

@@ -100,22 +100,18 @@
 - name: Grab local facts for looking up interfaces
   action: setup
   register: local_facts
-  when: sansible_kafka_interface_bind
-    or sansible_kafka_interface_advertise
+  when: sansible_kafka_interface_bind is not none
+    or sansible_kafka_interface_advertise is not none
 
 - name: Set listen_address if interface bind set
   set_fact:
-    kafka: "{{ kafka | combine( {
-        'listen_address': local_facts.ansible_facts['ansible_' + sansible_kafka_interface_bind]['ipv4']['address']
-      }, recursive=True) }}"
-  when: sansible_kafka_interface_bind
+    sansible_kafka_listen_address: "{{ local_facts.ansible_facts['ansible_' + sansible_kafka_interface_bind]['ipv4']['address'] }}"
+  when: sansible_kafka_interface_bind is not none
 
 - name: Set advertised_host_name if interface advertise set
   set_fact:
-    kafka: "{{ kafka | combine( {
-        'advertised_host_name': local_facts.ansible_facts['ansible_' + sansible_kafka_interface_advertise]['ipv4']['address']
-      }, recursive=True) }}"
-  when: sansible_kafka_interface_advertise
+    sansible_kafka_advertised_host_name: "{{ local_facts.ansible_facts['ansible_' + sansible_kafka_interface_advertise]['ipv4']['address'] }}"
+  when: sansible_kafka_interface_advertise is not none
 
 - name: Setup environment config
   become: yes