Skip to content

Commit

Permalink
Updating textContent attribute test for IE9
Browse files Browse the repository at this point in the history
The test page is loaded in Quirks mode in IE9, which means that IE doesn't
return a textContent attribute for that page. The alternatives are to
force the test page to load in Standards mode by adding a doctype, or
ignore the test for IE9. This commit chooses the latter approach.
  • Loading branch information
jimevans committed Dec 22, 2015
1 parent 7ee7a23 commit b58bc8c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions dotnet/test/common/ElementAttributeTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,9 @@ public void ShouldTreatReadonlyAsAValue()
[Test]
public void ShouldReturnHiddenTextForTextContentAttribute()
{
if (TestUtilities.IsOldIE(driver))
if (!TestUtilities.IsIE10OrHigher(driver))
{
Assert.Ignore("IE 8 or below does not handle textContent attribute");
Assert.Ignore("IE8 or below does not handle textContent attribute; IE9 loads page in quirks mode, so no textContent attribute");
}

driver.Url = simpleTestPage;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ public void testShouldTreatReadonlyAsAValue() {

@Test
public void testShouldReturnHiddenTextForTextContentAttribute() {
assumeFalse("IE before 9 doesn't handle textContent attribute", TestUtilities.isOldIe(driver));
assumeFalse("IE before 9 doesn't handle textContent attribute; IE9 loads page in quirks mode, so no textContent attribute", TestUtilities.getIEVersion(driver) < 10);

driver.get(pages.simpleTestPage);

Expand Down

0 comments on commit b58bc8c

Please sign in to comment.