Skip to content

Commit

Permalink
Use pubspec_parse dependency equality (#2254)
Browse files Browse the repository at this point in the history
  • Loading branch information
nex3 authored May 29, 2024
1 parent 5121eb1 commit fc24fec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ dev_dependencies:
lints: ">=2.0.0 <5.0.0"
protoc_plugin: ">=20.0.0 <22.0.0"
pub_api_client: ^2.1.1
pubspec_parse: ^1.0.0
pubspec_parse: ^1.3.0
test: ^1.16.7
test_descriptor: ^2.0.0
test_process: ^2.0.0
Expand Down
10 changes: 2 additions & 8 deletions test/double_check_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,8 @@ void main() {
});

test("matches dartdoc version", () {
// TODO(nweiz): Just use equals() once dart-lang/pubspec_parse#127 lands
// and is released.
var sassDep = sassPubspec.devDependencies["dartdoc"];
var pkgDep = pkgPubspec.devDependencies["dartdoc"];
expect(pkgDep, isA<HostedDependency>());
expect(sassDep, isA<HostedDependency>());
expect((pkgDep as HostedDependency).version,
equals((sassDep as HostedDependency).version));
expect(sassPubspec.devDependencies["dartdoc"],
equals(pkgPubspec.devDependencies["dartdoc"]));
});
});
}
Expand Down

0 comments on commit fc24fec

Please sign in to comment.