Exports quote and unquote functions for C bindings #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to exchange strings with registered functions.
HamptonMakes
added a commit
that referenced
this pull request
Oct 16, 2014
Exports quote and unquote functions for C bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to exchange strings with registered custom functions.
Libsass passes strings in quoted form inclusive quotemarks to the C bindings. I guess this is also how it is handled internally (I see a lot of unquote stuff going on in functions.cpp). IMO it would have been better to unquote on reading and quote on output if needed. Probably too late now. So this should be handy for all C Bindings if they have to consume or return strings in custom functions.