Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript declaration file to package.json #5

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

colinking
Copy link
Contributor

@colinking colinking commented Oct 22, 2018

Looks like I forgot to add the declaration file to the files field in the package.json in #4, so they weren't shipped when released to npm.

v0.2.0:

$ list-npm-contents jest-file-snapshot
package.json
index.js
README.md

After this PR:

$ npm pack
npm notice
npm notice 📦  jest-file-snapshot@0.2.0
npm notice === Tarball Contents ===
npm notice 979B  package.json
npm notice 396B  index.d.ts
npm notice 2.2kB index.js
npm notice 1.1kB README.md
npm notice === Tarball Details ===
npm notice name:          jest-file-snapshot
npm notice version:       0.2.0
npm notice filename:      jest-file-snapshot-0.2.0.tgz
npm notice package size:  2.0 kB
npm notice unpacked size: 4.6 kB
npm notice shasum:        6880305656815d438e67876fa9f26b7ee3117f29
npm notice integrity:     sha512-a1ljwOt1WgWmU[...]7pdfKEcmFYWcA==
npm notice total files:   4
npm notice
jest-file-snapshot-0.2.0.tgz

Looks like I forgot to add the declaration file to the `files` field in the `package.json` in satya164#4, so they weren't shipped when released to npm.
@colinking
Copy link
Contributor Author

Hey @satya164! Just checking in to see if you've had a chance to take a look at this PR. Thanks!

@satya164 satya164 merged commit 858ac38 into satya164:master Oct 29, 2018
colinking added a commit to colinking/jest-file-snapshot that referenced this pull request Oct 29, 2018
Probably should have added some tests with satya164#5 to catch this earlier :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants