Ability to set SSL version explicitly #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interesting find. would you have time adding support for the other adapters as well? |
|
I didn't have time to investigate the other adapters for such option... I can take a look over the weekend. |
Closed
Merged
|
merged #64 |
|
merged support for specifying an ssl version into master and updated the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had live nightmare this night.
I had to set SSL version to TLS v1 for one important service using Savon.
On ruby 1.8.7 EE it worked nicely, but 1.9.3 uses "SSLv23" auto-negotiate by default, which results in SSL verify errors.
And since Savon uses HTTPI I couldn't set this version no matter how hard I tried.
So I went monkeypatching frenzy.
This patch is not complete (e.g. it doesn't set ssl version on Net::HTTP and HTTPClient adapters), but its just a demo how I did this and I want you to see if it's a good idea to add this functionality.