Skip to content

Commit

Permalink
KristianRosenvold: Avoid flushing empty buffers since that makes it h…
Browse files Browse the repository at this point in the history
…ard to write error on exception

r16448
  • Loading branch information
krosenvold committed Apr 4, 2012
1 parent 9283ede commit 86ec241
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions java/server/src/org/openqa/grid/internal/TestSession.java
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,6 @@ public String forward(SeleniumBasedRequest request, HttpServletResponse response
HttpRequest proxyRequest = prepareProxyRequest(request/*, config*/);

HttpResponse proxyResponse = sendRequestToNode(proxyRequest);

lastActivity = timeSource.currentTimeInMillis();

final int statusCode = proxyResponse.getStatusLine().getStatusCode();
Expand Down Expand Up @@ -265,11 +264,10 @@ public String forward(SeleniumBasedRequest request, HttpServletResponse response
wrappedResponse.setForwardedContent(contentBeingForwarded);
((CommandListener) slot.getProxy()).afterCommand(this, request, wrappedResponse);
}
response.flushBuffer();
return res;
} finally {
forwardingRequest = false;
// Flushing the buffer is important to avoid concurrency problems
response.flushBuffer();
Thread.currentThread().setName(currentThreadName);
}
}
Expand Down

0 comments on commit 86ec241

Please sign in to comment.