Skip to content

Commit

Permalink
Re-ignoring failing Java cookie tests for IE
Browse files Browse the repository at this point in the history
Two of the three tests are also ignored for all major browsers. The third
exposes an edge case in the new cookie handling, which is that it's not
possible to get the "secure" flag for session cookies, only persisted
cookies.
  • Loading branch information
jimevans committed Jun 25, 2015
1 parent 84ac6da commit 996e551
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ public void testsShouldNotGetCookiesRelatedToCurrentDomainWithoutLeadingPeriod()
assertCookieIsNotPresentWithName(cookieName);
}

@Ignore({REMOTE,})
@Ignore({REMOTE})
@Test
public void testShouldBeAbleToIncludeLeadingPeriodInDomainName() throws Exception {
String cookieName = "name";
Expand Down Expand Up @@ -381,7 +381,7 @@ public void testRetainsCookieExpiry() {
assertEquals(addedCookie.getExpiry(), retrieved.getExpiry());
}

@Ignore(value = {PHANTOMJS, SAFARI})
@Ignore(value = {IE, PHANTOMJS, SAFARI})
@Test
public void testRetainsCookieSecure() {
driver.get(domainHelper.getSecureUrlForFirstValidHostname("animals"));
Expand All @@ -400,7 +400,7 @@ public void testRetainsCookieSecure() {
assertTrue(retrieved.isSecure());
}

@Ignore(value = {CHROME, FIREFOX, HTMLUNIT, PHANTOMJS, SAFARI})
@Ignore(value = {CHROME, FIREFOX, IE, HTMLUNIT, PHANTOMJS, SAFARI})
@Test
public void testRetainsHttpOnlyFlag() {
Cookie addedCookie =
Expand Down Expand Up @@ -447,7 +447,7 @@ public void testDeleteNotExistedCookie() {
driver.manage().deleteCookieNamed(key);
}

@Ignore(value = {CHROME, FIREFOX, PHANTOMJS, SAFARI})
@Ignore(value = {CHROME, FIREFOX, IE, PHANTOMJS, SAFARI})
@Test
public void testShouldDeleteOneOfTheCookiesWithTheSameName() {
driver.get(domainHelper.getUrlForFirstValidHostname("/common/animals"));
Expand Down

0 comments on commit 996e551

Please sign in to comment.