Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ID3 data for "Tausendfüßler" #606

Closed
tueddy opened this issue Nov 8, 2023 · 5 comments
Closed

Wrong ID3 data for "Tausendfüßler" #606

tueddy opened this issue Nov 8, 2023 · 5 comments

Comments

@tueddy
Copy link

tueddy commented Nov 8, 2023

Hi Wolle,

In general the ID3 tag information works very well but in this case i get wrong result.
Expected:

Album: "Eule findet den Beat - mit Gefühl (Musik-Hörspiel)"
Title: "Der Tausendfüßler und die Ukulele"

Got:

...
I [38680] info : ID3 normal frames
I [38842] id3data : SettingsForEncoding: Lavf58.29.100
I [39002] id3data : Alb
I [39161] id3data : Artist: Eule
I [39324] id3data : Tit
...

Encoding seems to be 0=ASCII, maybe a problem with "üß"?

Tausendfüßler.zip

@schreibfaul1
Copy link
Owner

Hi tueddy,
the error occurs when the metadata is neither Uincode nor pure ASCII. In this case, the ID3 data is in ISO_8859-1 format. I have now taken this into account.

best regards
Wolle

@tueddy
Copy link
Author

tueddy commented Nov 12, 2023

Work's like a charme, thank's for the very fast fix!

@tueddy tueddy closed this as completed Nov 12, 2023
@tueddy
Copy link
Author

tueddy commented Nov 13, 2023

Sorry to reopen but i found some kind of regression.
Attached MP3 was fine before but with this fix it shows wrong ID3 data (ü-Umlaut)

Before this fix:
id3data : Title: findet den Beat - mit Gefühl

Now:
id3data : Title: findet den Beat - mit Gef

Eule - findet den Beat - mit Gefühl.zip

@schreibfaul1
Copy link
Owner

That looks quite good to me
image
In the metadata there are still control characters like carriage return, I filtered them all out, but maybe I missed something?

@tueddy
Copy link
Author

tueddy commented Nov 13, 2023

Sorry, i forget to make a clean + full build after update ;-(
Everything works as expected now, thanks!

tueddy added a commit to biologist79/ESPuino that referenced this issue Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants