New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setNoDelay needs a valid fd. #135

Merged

schreibfaul1 merged 1 commit into schreibfaul1:master from CelliesProjects:disableNagle

Mar 17, 2021

Contributor

CelliesProjects commented Mar 17, 2021

Hi Wolle.

The previous commit was not tested enough.

This should be the correct implementation.
The client filedescriptor (fd) needs to be valid (non NULL) for setNoDelay() to function.


          setNoDelay needs a valid fd.

0b27c15

schreibfaul1 marked this pull request as ready for review

March 17, 2021 21:12

schreibfaul1 merged commit 8ab5584 into schreibfaul1:master

Owner

schreibfaul1 commented Mar 17, 2021

Hi Cellie,
Yes then we do it like that. The first variant worked for me. I saw no mistake.
Best regards
Wolle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment