ID3 Parsing: Only convert unicode if framesize > 1 #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current id3 parsing code leads to a lock-up of the cpu if the
framesize is 1 and unicode conversion needs to be done. This is since
i = framesize -1
and the conversion loop condition is m<i-1. For framesize = 1 -> i=0 and
the condition m<-1 for unit16_t m keeps the cpu busy for a while and
reads way above the memory boundary of the array 'value' inside the loop.
This patch fixes the problem by not entering the unicode conversion if
the framesize is <= 1.