-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ak_to_feather and ak_from_feather functions #2683
Conversation
Hi! |
Codecov Report
Additional details and impacted files
|
When you're ready (when the docstrings are done and you've done "Update branch" with no errors), do "Ready for review" and assign me as the reviewer. |
Oh, I just remembered something: we want the new functions to show up in the documentation, too. They need to be added to the right sections of docs/reference/toctree.txt, and then they'll show up when you press the "View deployment" button, followed by "API reference", in the left side-bar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a few twisted changes, mostly described below.
Did you see the generated documentation? In the last "View Deployment" button, the documentation for the two functions are rendered at
and
feather_version=2, | ||
version=2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good for this to be called feather_version
, since it would be ambiguous what the "version" is referring to otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! I just made a few small changes before merging because they'd be easier to apply than to describe.
I'll give you a chance to make counter-edits, but I think this is ready to squash-and-merge.
@all-contributors please add @zbilodea for code |
I've put up a pull request to add @zbilodea! 🎉 |
No description provided.